Remove dark mode

[sstefdev]

Problem

Dark mode had some of the components with wrong colors and background-color

Solution

• added color-scheme property on all of the web-components

Summary by CodeRabbit

• New Features
  • Added support for light mode styling in the invoice form and dashboard components.
• Bug Fixes
  • Incremented version numbers for both @requestnetwork/create-invoice-form and @requestnetwork/invoice-dashboard packages, indicating minor improvements and bug fixes.
• Style
  • Enhanced visual presentation by adding color-scheme: light; to global styles in both components.
• Refactor
  • Improved readability of conditional rendering in the invoice dashboard component.

[coderabbitai]

Walkthrough

This pull request includes version updates for two packages: @requestnetwork/create-invoice-form and @requestnetwork/invoice-dashboard, reflecting minor improvements and bug fixes. Additionally, both packages have introduced a new CSS property color-scheme: light; in their respective Svelte component files, enhancing styling capabilities for light mode. The changes primarily focus on version management and minor styling adjustments without altering core functionality.

Changes

File	Change Summary
packages/create-invoice-form/package.json	Updated version from 0.8.0 to 0.8.1.
packages/create-invoice-form/src/lib/create-invoice-form.svelte	Added color-scheme: light; to global styles.
packages/invoice-dashboard/package.json	Updated version from 0.7.0 to 0.7.1.
packages/invoice-dashboard/src/lib/view-requests.svelte	Minor formatting adjustments in conditional rendering; added color-scheme: light; to global styles.

Possibly related PRs

• chore: increase version for V2 release #84: This PR also updates the version of the @requestnetwork/create-invoice-form package in package.json, indicating a similar focus on version management.
• chore: increase package size for release #125: This PR updates the version of the @requestnetwork/create-invoice-form package from 0.7.0 to 0.8.0, which is directly related to the version update in the main PR.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between f95de9b and d9d0d5d.

Files selected for processing (4)

• packages/create-invoice-form/package.json (1 hunks)
• packages/create-invoice-form/src/lib/create-invoice-form.svelte (1 hunks)
• packages/invoice-dashboard/package.json (1 hunks)
• packages/invoice-dashboard/src/lib/view-requests.svelte (2 hunks)

Additional comments not posted (5)

packages/create-invoice-form/package.json (1)

3-3: LGTM!

The version change from 0.8.0 to 0.8.1 follows semantic versioning and indicates backwards-compatible bug fixes or minor improvements. This change is unlikely to introduce any breaking changes.

packages/invoice-dashboard/package.json (1)

3-3: LGTM! Ensure the release notes are reviewed.

The minor version bump from 0.7.0 to 0.7.1 suggests backward-compatible bug fixes or improvements. This change itself does not introduce any breaking changes or compatibility issues.

However, it is important to review the release notes or changelog to understand the exact nature of the updates and their potential impact on the project.

To verify the changes, run the following script:

Verification successful

---

Version update confirmed, but changelog missing

The version update to 0.7.1 in packages/invoice-dashboard/package.json is confirmed and matches the review comment. However, there are some important points to note:

• No CHANGELOG.md or release notes file was found in the repository.
• The package-lock.json file contains a reference to a pre-release version "0.7.1-next.2043+d9feda6f".

Without a changelog or release notes, it's challenging to determine the exact nature of the changes in this version update. Consider the following recommendations:

• Implement a CHANGELOG.md file to track changes between versions.
• Manually verify the changes between versions 0.7.0 and 0.7.1 to ensure they align with the minor version bump.
• Review the pre-release version in package-lock.json to ensure it's intentional and doesn't conflict with the released version.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the release notes for version 0.7.1.

# Test: Search for a CHANGELOG.md file in the package directory.
# Expect: CHANGELOG.md file to exist.
fd --type f --max-depth 1 --base-directory packages/invoice-dashboard/ --regex '^CHANGELOG\.md$'

# Test: Search for release notes specific to version 0.7.1 in the CHANGELOG.md file.
# Expect: Release notes for version 0.7.1 to be present.
rg --type markdown --max-count 1 --max-depth 1 --base-directory packages/invoice-dashboard/ $'## \[0\.7\.1\]'

Length of output: 628

---

Script:

#!/bin/bash
# Description: Re-verify the release notes for version 0.7.1

# Test: Search for a CHANGELOG.md file in the repository
# Expect: CHANGELOG.md file to exist
fd CHANGELOG.md

# Test: Search for release notes specific to version 0.7.1 in the CHANGELOG.md file
# Expect: Release notes for version 0.7.1 to be present
rg --type markdown --max-count 1 '## \[0\.7\.1\]' $(fd CHANGELOG.md)

Length of output: 88

---

Script:

#!/bin/bash
# Description: Search for changelog, release notes, and version information

# Test: Search for any changelog or release notes files
# Expect: To find files related to changelogs or release notes
fd -i 'changelog|release.?notes'

# Test: Check for version information in package.json
# Expect: To find version 0.7.1 in package.json
rg '"version":\s*"0\.7\.1"' $(fd package.json)

# Test: Search for any mentions of version 0.7.1 in the repository
# Expect: To find references to version 0.7.1
rg '0\.7\.1'

Length of output: 651

packages/create-invoice-form/src/lib/create-invoice-form.svelte (1)

260-260: LGTM!

The addition of the color-scheme: light; property to the global styles is a good enhancement. It allows the browser to optimize the rendering of form controls and other elements for better consistency with the light theme, improving the visual presentation and user experience.

packages/invoice-dashboard/src/lib/view-requests.svelte (2)

500-501: LGTM!

The additional parentheses around the conditional expressions enhance readability without altering the functionality. The change is purely stylistic and can be safely merged.

---

627-627: Looks good!

The addition of the color-scheme: light; CSS property is a valid change that informs the browser about the component's color scheme optimization. This change is purely stylistic and does not introduce any functional issues.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.