fix(data-format): remove invoice item currency constraints#852
Merged
alexandre-abrioux merged 5 commits intomasterfrom May 31, 2022
Merged
fix(data-format): remove invoice item currency constraints#852alexandre-abrioux merged 5 commits intomasterfrom
alexandre-abrioux merged 5 commits intomasterfrom
Conversation
github-actions
bot
requested review from
KolevDarko,
kevindavee,
leoslr and
yomarion
kevindavee
approved these changes
May 30, 2022
yomarion
approved these changes
May 30, 2022
packages/data-format/src/format/rnf_invoice/rnf_invoice-0.0.1.json
Outdated
Show resolved
Hide resolved
benjlevesque
approved these changes
May 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need for constraints on invoice items' currency string. The currency name can be longer than 10 characters, for instance
ETH-rinkeby(11 characters). I chose to update past format versions to fix the bug everywhere it was present. I consider this operation as safe as it is a constraint removal. Let me know if you would prefer only updating the latest version, or even creating a whole new version instead.