fix(ethereum-storage): OldNonce error, wait for 1 confirmation when submitting hashes #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
alexandre-abrioux,
benjlevesque,
kevindavee and
KolevDarko
MantisClone
changed the title
kevindavee
approved these changes
Feb 28, 2023
- Ethereum and Gnosis Chain freuquently experience 1-block reorgs
So 2 confirmations are required to ensure block finality in most
cases.
| @@ -17,6 +17,7 @@ const config = { | |||
| retryDelay: 0, | |||
| safeGasPriceLimit: '500000000000', | |||
| transactionPollingTimeout: 300, | |||
| blockConfirmations: 2, | |||
There was a problem hiding this comment.
I don't think this is ever used
There was a problem hiding this comment.
Fixed, see comment below. it's used now.
| * Retrieve from config the default number of block confirmations to wait before considering a transaction successful | ||
| * @returns the number of block confirmations | ||
| */ | ||
| export function getDefaultEthereumBlockConfirmations(): number { |
There was a problem hiding this comment.
Fixed. I called it as a fallback.
| return ( | ||
| (argv.blockConfirmations && Number(argv.blockConfirmations)) || | ||
| (process.env.BLOCK_CONFIRMATIONS && Number(process.env.BLOCK_CONFIRMATIONS)) || | ||
| defaultValues.ethereumStorage.ethereum.blockConfirmations |
There was a problem hiding this comment.
this is never set, see at the top of this file
benjlevesque
approved these changes
Mar 7, 2023
olivier7delf
approved these changes
Mar 7, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1074
Fixes #1075
Fixes dw-97
Changes: