feat: replace hardhat ganache #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
alexandre-abrioux,
KolevDarko,
olivier7delf and
yomarion
leoslr
commented
Feb 24, 2023
| * - Less than 20% difference between two consecutive estimations | ||
| * - Less than 40% difference between the first and the last estimations | ||
| */ | ||
| it('Should return a consistent value after several transactions', async () => { |
There was a problem hiding this comment.
Open to suggestion to improve this. It's not very practical to test..
|
Looks good so far. Those erc777 payment processor tests are failing tho :( |
olivier7delf
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
Replace the hardhat-ganache plugin by hardhat:
Update the eip159 lib and add tests for it.