Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in RN SDK release process #1381

Closed
4 tasks done
MantisClone opened this issue Apr 2, 2024 · 3 comments
Closed
4 tasks done

Fix bugs in RN SDK release process #1381

MantisClone opened this issue Apr 2, 2024 · 3 comments
Assignees

Comments

@MantisClone
Copy link
Member

MantisClone commented Apr 2, 2024

Problems

  • While releasing 0.46.0, the release branch wasn't merged to master. This release branch is supposed to update the dependencies between packages and update the change log. 🤙 Not a Problem
  • the CHANGELOG.md files for each package did not update correctly. Weird duplicates of the 0.41.0 CHANGELOG - 🙅 Won't Fix (at least not now. Maybe later)
  • The github release description was missing the CHANGELOG section, even thought it was correctly generated by the release script.
  • Release gets the wrong title

Image

Proposed Solution

Fix errors in the private https://github.com/RequestNetwork/release-tools repo

@MantisClone MantisClone changed the title Fix bugs in release process Fix bugs in RN SDK release process Apr 2, 2024
@MantisClone
Copy link
Member Author

While releasing 0.46.0, the release branch wasn't merged to master. This release branch is supposed to update the dependencies between packages and update the change log.

The release branch created as part of the release.sh script is supposed to be merged after publishing to NPM. Therefore, the first problem listed in the issue description is not a problem

@MantisClone
Copy link
Member Author

the CHANGELOG did not update correctly. Weird duplicates of the 0.41.0 CHANGELOG

Likely caused by: Publish does not detect manually created tags in fixed mode with Github/Github Enterprise

@MantisClone
Copy link
Member Author

I wrote a script in https://github.com/RequestNetwork/release-tools/pull/5 that replaces the un-annotated tags with annotated ones.
I replaced the un-annotated tags with annotated ones.

mantisclone@mantisclone-Inspiron-7620:~/projects/requestNetwork$ git push --tags --force
Enumerating objects: 22, done.
Counting objects: 100% (22/22), done.
Delta compression using up to 20 threads
Compressing objects: 100% (22/22), done.
Writing objects: 100% (22/22), 1.31 KiB | 1.31 MiB/s, done.
Total 22 (delta 21), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (21/21), done.
To github.com:RequestNetwork/requestNetwork.git
 + 58050fa9...4dd2ffbc @requestnetwork/advanced-logic@0.27.0 -> @requestnetwork/advanced-logic@0.27.0 (forced update)
 + 58050fa9...36f780ad @requestnetwork/data-access@0.23.0 -> @requestnetwork/data-access@0.23.0 (forced update)
 + 58050fa9...edb379ee @requestnetwork/data-format@0.8.0 -> @requestnetwork/data-format@0.8.0 (forced update)
 + 58050fa9...728c6991 @requestnetwork/docs@0.1.16 -> @requestnetwork/docs@0.1.16 (forced update)
 + 58050fa9...19bf198f @requestnetwork/epk-decryption@0.3.24 -> @requestnetwork/epk-decryption@0.3.24 (forced update)
 + 58050fa9...9efc3ef3 @requestnetwork/epk-signature@0.5.25 -> @requestnetwork/epk-signature@0.5.25 (forced update)
 + 58050fa9...955db861 @requestnetwork/ethereum-storage@0.22.0 -> @requestnetwork/ethereum-storage@0.22.0 (forced update)
 + 58050fa9...83619ed3 @requestnetwork/integration-test@0.27.0 -> @requestnetwork/integration-test@0.27.0 (forced update)
 + 58050fa9...94dbecf4 @requestnetwork/multi-format@0.15.0 -> @requestnetwork/multi-format@0.15.0 (forced update)
 + 58050fa9...6685af50 @requestnetwork/payment-detection@0.30.0 -> @requestnetwork/payment-detection@0.30.0 (forced update)
 + 58050fa9...5fa91418 @requestnetwork/payment-processor@0.30.0 -> @requestnetwork/payment-processor@0.30.0 (forced update)
 + 58050fa9...f34f00c1 @requestnetwork/prototype-estimator@1.21.0 -> @requestnetwork/prototype-estimator@1.21.0 (forced update)
 + 58050fa9...d1028381 @requestnetwork/request-client.js@0.30.0 -> @requestnetwork/request-client.js@0.30.0 (forced update)
 + 58050fa9...96966489 @requestnetwork/request-logic@0.26.0 -> @requestnetwork/request-logic@0.26.0 (forced update)
 + 58050fa9...f30efba7 @requestnetwork/request-node@0.23.0 -> @requestnetwork/request-node@0.23.0 (forced update)
 + 58050fa9...971046c3 @requestnetwork/smart-contracts@0.21.0 -> @requestnetwork/smart-contracts@0.21.0 (forced update)
 + 58050fa9...514acf32 @requestnetwork/toolbox@0.1.24 -> @requestnetwork/toolbox@0.1.24 (forced update)
 + 58050fa9...a0f1429f @requestnetwork/transaction-manager@0.26.0 -> @requestnetwork/transaction-manager@0.26.0 (forced update)
 + 58050fa9...aab8b5be @requestnetwork/types@0.29.0 -> @requestnetwork/types@0.29.0 (forced update)
 + 58050fa9...c1876aeb @requestnetwork/usage-examples@0.23.0 -> @requestnetwork/usage-examples@0.23.0 (forced update)
 + 58050fa9...3269578d @requestnetwork/utils@0.28.0 -> @requestnetwork/utils@0.28.0 (forced update)
 + 58050fa9...fcfca908 @requestnetwork/web3-signature@0.4.26 -> @requestnetwork/web3-signature@0.4.26 (forced update)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

No branches or pull requests

1 participant