Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: goerli #30

Merged
merged 5 commits into from
Oct 7, 2022
Merged

feat: goerli #30

merged 5 commits into from
Oct 7, 2022

Conversation

benjlevesque
Copy link
Contributor

@benjlevesque benjlevesque commented Oct 7, 2022 •
edited
Loading

No description provided.

@benjlevesque benjlevesque requested review from bertux and omarspx October 7, 2022 12:43
@benjlevesque benjlevesque changed the title feat/goerli feat: goerli Oct 7, 2022
@benjlevesque benjlevesque merged commit 84c2d4c into master Oct 7, 2022
@benjlevesque benjlevesque deleted the feat/goerli branch October 7, 2022 14:11
bertux
bertux approved these changes Oct 7, 2022
View reviewed changes
Copy link

@bertux bertux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this upgrade

.github/workflows/create-deploy-staging.yml
@@ -2,15 +2,19 @@ name: "[Create] Deploy to staging"

on: [push]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

starting on every push seems too much

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why that?

Copy link
Contributor Author

@benjlevesque benjlevesque Oct 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is what we do for every repo/CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertux bertux bertux approved these changes

@omarspx omarspx omarspx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjlevesque @bertux @omarspx