Skip to content

Conversation

@Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented May 10, 2024

relates to #478

  • about_this_doc should become a CONTRIBUTING.md
  • remove numbers prefix in filenames
  • ensure that all code blocks have syntax highlighting
  • ensure proper formatting of markdown by applying remark linting rules

@Remi-Gau
Copy link
Collaborator Author

That's a lot of line changes but mostly because of applying the remark markdown linting.

@Remi-Gau
Copy link
Collaborator Author

will implement the other changes from #478 in a follow-up PR to help with review

Copy link
Contributor

@yibeichan yibeichan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! i left some comments there; once we resolve them, we can merge this one

Copy link
Contributor

@yibeichan yibeichan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good, good; there are only two filenames we may want to change from _ to - if remarks doesn't complain. then, everything should be consistent

@Remi-Gau
Copy link
Collaborator Author

@yibeichan
will let you merge if you think this is good to go

@yibeichan yibeichan merged commit 3a8aa0c into ReproNim:master May 12, 2024
@Remi-Gau Remi-Gau deleted the fix/doc branch June 17, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants