Fix issue 230 #236
Merged
Fix issue 230 #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esDir call since the first one is deprecated in API level 29.
|
This helped me a lot. Thank you for solving this issue. Should be merged into main project |
|
@avenyproduction you are welcome! 😊 |
john1jan
approved these changes
May 25, 2021
|
@jedt this PR seems to meet the guidelines and is approved by @john1jan . Any chance it can be merged with a new release? |
|
Thanks so much for merging this @jedt 👏. Any chance we could get a new release also? |
|
Hi @MrHubble just published the master branch can you please test for any issues? |
|
I've tested the latest release on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace getExternalStorageDirectory function call with getExternalFilesDir call since the first one is deprecated in API level 29.
Fix #230