Download files issue

[socpl425]

Hi,
I'm using cam.get_file( .. ) to download from cam.get_motion_files(start=start, end=end, streamtype=streamtype) .

It works great, but sometimes it seems to just hang and never finish download. At that point it also looks like the Reolink android app has issues connecting to camera, at least the settings page. If I manually kill (ctrl C!) my program and start over again it works to download and back to normal.

Is it possible to add a timeout function to get_file operation? Just kill it if it does not work after N seconds..

Camera: RLC 410W 4MP

Thanks! love the api

[Benehiko]

Hi thank you for using the library! :)

So afaik the requests should auto timeout after about 1 second (the default state set in the code).
See

reolinkapipy/reolinkapi/handlers/api_handler.py

Line 127 in 5ac45d8

with requests.get(self.url, params=params, stream=True, verify=False, timeout=(1, None)) as req:

It might be an issue that the post requests don't have a specific timeout

reolinkapipy/reolinkapi/handlers/rest_handler.py

Line 20 in 5ac45d8

r = requests.post(url, verify=False, params=params, json=data, headers=headers,

You could try add it in the code and see if the results change.

PR's are welcome! :)

[socpl425]

Thanks! And thanks for all contributions

I can't consistently reproduce the issue, but I will try the timeout as suggested in post.

Also separately, I had a "get snap" program running continuously where I did not use logout function so maybe I inadvertently caused some of the issues on the reolink side. After I added a logout, seems like this non "timeout" issue is not occuring. But again, might be totally unrelated:)