Micro-interaction #58#72
Merged
Merged
Conversation
feat(button): add ripple effect and loading-spinner micro-interaction to NEXT STEP button on Tickets-page
fatimahilali
approved these changes
May 23, 2025
fatimahilali
left a comment
fatimahilali
left a comment
Collaborator
There was a problem hiding this comment.
Wat goed gaat:
- Je gebruikt semantische HTML-elementen zoals
<article>,<label>,<strong>,<aside>, en<button>. - Je houdt rekening met progressive enhancement: er is een fallback als JavaScript uitstaat.
Waar je nog op kunt letten:
- Gebruik bij afbeeldingen het
<picture>-element enwidthenheightvoor betere performance. - Voeg een eenvoudige
try...catchtoe rond GET-requests voor betere foutafhandeling. - Ik zie geen media queries. Werk je wel mobile-first? Begin met mobiele styling en voeg daarna desktop toe.
Karima002
approved these changes
May 23, 2025
Karima002
left a comment
Karima002
left a comment
Collaborator
There was a problem hiding this comment.
Goed gedaan! Ik heb nog een aantal feedback punten:
- Probeer de pull request in te vullen aan de hand van de template. Zie hiervoor deze issue: #36 (comment)
- Gebruik comments in je code. Ik merk met name bij de javascript dat ik niet goed begrijp wat daar gebeurt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(button): add ripple effect and loading-spinner micro-interaction to NEXT STEP button on Tickets-page