Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server/main) export to create job account #74

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

t1ger-scripts
Copy link

Added an export CreateJobAccount() to add new job accounts in runtime. Very useful for scripts utilizing in-game job/shop creators.

Added an export CreateJobAccount() to add new job accounts in runtime. Very useful for scripts utilizing in-game job/shop creators.
@solareon
Copy link
Contributor

Is there a reason to return the cachedAccount table back to the export caller? I believe this should return true/false with true being the account was created and false if the account exists or fails to create.

@t1ger-scripts
Copy link
Author

t1ger-scripts commented Oct 29, 2024

Is there a reason to return the cachedAccount table back to the export caller? I believe this should return true/false with true being the account was created and false if the account exists or fails to create.

Very useful when creating accounts in runtime, avoiding calling another export to retrieve the account data of the newly created account. If you prefer true/false return, I can rework the commit - however; imo it makes sense to return the created account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants