Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Push container image to GHCR #95

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Conversation

onedr0p
Copy link
Contributor

@onedr0p onedr0p commented Mar 30, 2024

Hi @RemiRigal👋🏼 Awesome project here...

Dockerhub has aggressive pull rate limits, it would be awesome if you could push the image to Github Container Registry (GHCR) too.

Dockerhub was one of the best years ago... GHCR is completely free for open source projects. It's also nice in that it integrates into your repo under the packages section. Take a look at my project here and look at the packages on the right side.

Thanks!

Edit: This also bumps deps in the workflow

Hi 👋🏼 Awesome project here...

Dockerhub has aggressive pull rate limits, it would be awesome if you could push the image to Github Container Registry (GHCR) too.

Dockerhub was one of the best years ago... GHCR is completely free for open source projects. It's also nice in that it integrates into your repo under the packages section. Take a look at my project [here](https://github.com/onedr0p/exportarr) and look at the packages on the right side.

Thanks!

This also bumps deps in the workflow
@onedr0p
Copy link
Contributor Author

onedr0p commented Mar 30, 2024

@RemiRigal after this is merged and a release it cut you may have to make the package public. Thanks 👍🏼

with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This secret is auto-generated in the pipeline, no need to create a PAT.

@onedr0p
Copy link
Contributor Author

onedr0p commented Apr 5, 2024

This project appears to be dead or on life support, closing. I'll find an alternative.

@onedr0p onedr0p closed this Apr 5, 2024
@RemiRigal RemiRigal reopened this Apr 8, 2024
@RemiRigal
Copy link
Owner

Hi @onedr0p, apologies for the late reply I was busy in the past few days. This project is far from dead, I don't have as much time as I'd like to work on it but it remains functional and supported.

Thanks for the PR.

@RemiRigal RemiRigal merged commit d08a88a into RemiRigal:master Apr 8, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants