fix: align account settings tab backgrounds#38
Merged
Rello merged 1 commit intocodex/rebuild-settings-screen-with-left-menufrom Jan 19, 2026
Conversation
|
Artifact containing the AppImage: nextcloud-appimage-pr-38.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
75e42ca
into
codex/rebuild-settings-screen-with-left-menu
12 of 18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
QTabWidgetpane and tab pages had inconsistent backgrounds causing visual mismatch in the account settings dialog.QSizePolicyinclude was required to set the expanding policy for the embedded QML widget.Description
QTabWidgetstylesheet to usepalette(alternate-base)for the pane and for#standardSyncTab,#fileProviderTab, and#connectionSettingsTab.setAutoFillBackground(true)and setQt::WA_StyledBackgroundon the three tab pages to ensure the styled backgrounds are applied.QVBoxLayout::setSpacing(0), appliedQSizePolicy::Expandingto the file provider QML widget, and added the File Provider and Network Settings widgets with stretch1so they fill the available space.#include <QSizePolicy>to support the size policy usage.Testing
Codex Task