Skip to content

Hide menu bar while reports load #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rello merged 1 commit into from
Sep 13, 2025
Merged

Hide menu bar while reports load #546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
- Warn about unsaved changes before leaving a report

### Fixed
- Hide menu bar and show loading spinner while reports are loading
- Fix PHP 8.4 deprecation warnings #534 @[robertoschwald](https://github.com/robertoschwald)
- date formatting on all rows
- fix double report execution after wizard close
Expand Down
1 change: 1 addition & 0 deletions js/report.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,6 +784,7 @@ Object.assign(OCA.Analytics.Report.Backend = {
getData: function () {
if (OCA.Analytics.currentXhrRequest) OCA.Analytics.currentXhrRequest.abort();
OCA.Analytics.Report.resetContentArea();
OCA.Analytics.Visualization.showContentByType('loading');

// Build AJAX parameters from filter options
const ajaxData = ['filteroptions', 'dataoptions', 'chartoptions', 'tableoptions'].reduce((acc, option) => {
Expand Down
2 changes: 1 addition & 1 deletion js/visualization.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1341,7 +1341,7 @@ OCA.Analytics.Visualization = {
OCA.Analytics.currentContentType = type;
}
//}
if (type === 'intro' || type === 'warning') {
if (type === 'intro' || type === 'warning' || type === 'loading') {
OCA.Analytics.Visualization.hideElement('menuBar');
} else {
OCA.Analytics.Visualization.showElement('menuBar');
Expand Down