AB#112755 - Overlap text fix while exporting dashboards #2786
Conversation
| @@ -337,6 +337,8 @@ export const FIELD_EDITOR_CONFIG: RawEditorSettings = { | |||
| menubar: 'edit view insert format tools table help', | |||
| toolbar: | |||
| 'undo redo | bold italic underline strikethrough | fontselect fontsizeselect formatselect | alignleft aligncenter alignright alignjustify | outdent indent | numlist bullist | forecolor backcolor removeformat | charmap emoticons | fullscreen preview save | insertfile image media link avatar recordeditor', | |||
| paste_retain_style_properties: 'color font-size', | |||
There was a problem hiding this comment.
@HasnatL-Adapptlimited
does it do anything? the documentation indicates that this has been deprecated in version 5.10, which is the one we're using
|
Hey Antoine,
Yes, this maintains the colour and fontsize of the text whilst pasting, we tested both with and without this change.
Kind Regards,
Hasnat Lamina
Software Developer
________________________________
From: Antoine Hurard ***@***.***>
Sent: 22 April 2025 16:24
To: ReliefApplications/ems-frontend ***@***.***>
Cc: Hasnat Lamina ***@***.***>; Mention ***@***.***>
Subject: Re: [ReliefApplications/ems-frontend] Overlap text fix + Retain colour of text on paste (PR #2786)
CAUTION: This email came from outside of Adappt. Be wary of phishing, social engineering and malware. Just because it might come from a legitimate domain, does not mean that the mail is legitimate. Always verify requests for information or actions. "Trust but verify"
@AntoineRelief commented on this pull request.
________________________________
In libs/shared/src/lib/const/tinymce.const.ts<#2786 (comment)>:
@@ -337,6 +337,8 @@ export const FIELD_EDITOR_CONFIG: RawEditorSettings = {
menubar: 'edit view insert format tools table help',
toolbar:
'undo redo | bold italic underline strikethrough | fontselect fontsizeselect formatselect | alignleft aligncenter alignright alignjustify | outdent indent | numlist bullist | forecolor backcolor removeformat | charmap emoticons | fullscreen preview save | insertfile image media link avatar recordeditor',
+ paste_retain_style_properties: 'color font-size',
@HasnatL-Adapptlimited<https://github.com/HasnatL-Adapptlimited>
does it do anything? the documentation indicates that this has been deprecated in version 5.10, which is the one we're using
—
Reply to this email directly, view it on GitHub<#2786 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BAQADUVTPUL4JM7EW5AF3DD22ZNLHAVCNFSM6AAAAAB3K5ZNP6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOOBUGUYDONZUGM>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
| */ | ||
| ngAfterViewInit(): void { | ||
| // Find the element with the class "text-overlapping-fix" | ||
| const overlappedElement: HTMLElement | null = |
There was a problem hiding this comment.
@HasnatL-Adapptlimited
I don't think that's a valid solution because it limits the fix to the specific use case you build the fix for
using a class like that that the end user has to put in the html seems quite weird to me
There was a problem hiding this comment.
This is a very specific use case for EIS or any applications using the HTML-text-widget and importing data with MS-word styling.
Do you have any other suggestions for how this can be fixed without hindering other websites in the app builder? as its a very specific ( style paste/ import) issue
Also is there anyway to please set up a call and I can show you how it looks from my side (to try and replicate the overlapping issue) or maybe we can try and compare what is different from my screen and your screen? as I'm not sure why you can't replicate it from your side.
CC: @SafiMohammed
There was a problem hiding this comment.
I can be available tomorrow morning, starting from 9.30am CEST, all the morning
If that works for you I'll let you send a meeting link
There was a problem hiding this comment.
Hey @AntoineRelief scheduled a meeting for 11:00 CEST just seen you accepted, thanks!
|
I'll create a new PR and merge the changes of the tinymce.const file, but I won't merge yet the changes that would fix the export as mentioned in the ticket, I cannot replicate the issue. I tried with some of my colleagues and none of them could reproduce the issue |
|
@HasnatL-Adapptlimited |
AntoineRelief
changed the title
Description
Applied fix for overlapping text and spaces between pasted html text.
Useful links
Link to ticket: https://dev.azure.com/WHOHQ/EMSSAFE/_workitems/edit/112755
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Screenshots
Before:
After:
Checklist:
( * == Mandatory )
More explanation
https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145