Skip to content

feat/AB#88032_ABC-disable-cross-page-filtering-in-the-app-builder-as-well #2448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: beta
Choose a base branch
from

Conversation

unai-reliefapp
Copy link
Contributor

Description

  • feat: add Map to set any filter values for each one of the dashboards of the application in the app builder, filters are set only for each dashboard now
  • feat: clean Map once the user exits application remove: filterValues$ observable as is not used

Useful links

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please refer to video below

Screenshots

Compartir.pantalla.-.2024-03-13.17_37_03.mp4

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

…well feat: add Map to set any filter values for each one of the dashboards of the application in the app builder, filters are set only for each dashboard now feat: clean Map once the user exits application remove: filterValues$ observable as is not used
@unai-reliefapp unai-reliefapp added the enhancement New feature or request label Mar 13, 2024
@unai-reliefapp unai-reliefapp self-assigned this Mar 13, 2024
…tend into feat/AB#88032_ABC-disable-cross-page-filtering-in-the-app-builder-as-well
…tend into feat/AB#88032_ABC-disable-cross-page-filtering-in-the-app-builder-as-well
…well fix: use current unique dashboard id to save filter values instead survey questions as keys, as could be that same questions be set in different dashboards
@AntoineRelief AntoineRelief changed the base branch from 2.x.x to beta May 14, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant