Skip to content

feat/AB#87619_ABC-in-web-Widgets-when-navigating-between-pages-disable-screen-and-show-loading-indicator #2443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

unai-reliefapp
Copy link
Contributor

Description

  • feat: add loading and dashboard disable state for tab load as web-widgets

Useful links

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please refer to video below

Screenshots

Loading state between tab loading for SUI

Compartir.pantalla.-.2024-03-12.09_21_00.mp4

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@unai-reliefapp unai-reliefapp added the enhancement New feature or request label Mar 12, 2024
@unai-reliefapp unai-reliefapp self-assigned this Mar 12, 2024
@AntoineRelief
Copy link
Collaborator

@unai-reliefapp
did you try using navigationEnd / navigationStart events?

@unai-reliefapp
Copy link
Contributor Author

@unai-reliefapp did you try using navigationEnd / navigationStart events?

You are right, I tried with canDeactivate but didnt work and I left the route approach, it works with the router events also
I'll push it now, thanks

@AntoineRelief
Copy link
Collaborator

@unai-reliefapp

In addition, please push the logic about the loading indicator to the app-widget component

…e-screen-and-show-loading-indicator feat: add loading and dashboard disable state for tab load as web-widgets
@unai-reliefapp unai-reliefapp force-pushed the feat/AB#87619_ABC-in-web-Widgets-when-navigating-between-pages-disable-screen-and-show-loading-indicator branch from 310aeec to 423de7b Compare March 12, 2024 09:16
@unai-reliefapp
Copy link
Contributor Author

@AntoineRelief event approach ready 👍

…ating-between-pages-disable-screen-and-show-loading-indicator # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
@AntoineRelief AntoineRelief merged commit e23b163 into 2.x.x Mar 12, 2024
@AntoineRelief AntoineRelief deleted the feat/AB#87619_ABC-in-web-Widgets-when-navigating-between-pages-disable-screen-and-show-loading-indicator branch March 12, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants