Fix/ab#85861 infinite scrolling not triggered when elements take less space than height #2386
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I created a function to fetch more data if the cards height takes up less space than the container height when using infinite scrolling.
I noticed a bug related padding when scrolling to the bottom of the container. This was caused by the
max-height
property. I moved it, as it is only used by the preview in the settings.Additionally, I noticed an issue with resource loading when using infinite scrolling which I fixed by sending the query result along with the binding.
Useful links
Type of change
How Has This Been Tested?
I created a dashboard with the grid type option set to
fit
. I created a summary cards widget based on data with hundred of lines, that usesinfinite scrolling
. I styled the cards to have a minimum height so that at least 25 cards don't take up the full space. I checked if more cards were loaded (until the scrollbar appeared).Screenshots
Checklist:
( * == Mandatory )
More explanation
https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145