Skip to content

Fix/ab#85861 infinite scrolling not triggered when elements take less space than height #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: 2.x.x
Choose a base branch
from

Conversation

NathanHGit
Copy link
Contributor

@NathanHGit NathanHGit commented Feb 14, 2024

Description

I created a function to fetch more data if the cards height takes up less space than the container height when using infinite scrolling.

I noticed a bug related padding when scrolling to the bottom of the container. This was caused by the max-height property. I moved it, as it is only used by the preview in the settings.

Additionally, I noticed an issue with resource loading when using infinite scrolling which I fixed by sending the query result along with the binding.

Useful links

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I created a dashboard with the grid type option set to fit. I created a summary cards widget based on data with hundred of lines, that uses infinite scrolling. I styled the cards to have a minimum height so that at least 25 cards don't take up the full space. I checked if more cards were loaded (until the scrollbar appeared).

Screenshots

peek

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@NathanHGit NathanHGit self-assigned this Feb 14, 2024
@NathanHGit NathanHGit added the bug Something isn't working label Feb 14, 2024
@NathanHGit NathanHGit requested a review from a team February 15, 2024 09:58
@NathanHGit NathanHGit marked this pull request as ready for review February 15, 2024 09:58
@estelafs estelafs requested review from estelafs and removed request for a team February 15, 2024 12:16
…n_elements_take_less_space_than_height # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
@NathanHGit NathanHGit changed the title Fix/ab#infinite scrolling not triggered when elements take less space than height Fix/ab#85861infinite scrolling not triggered when elements take less space than height Feb 19, 2024
@NathanHGit NathanHGit changed the title Fix/ab#85861infinite scrolling not triggered when elements take less space than height Fix/ab#85861 infinite scrolling not triggered when elements take less space than height Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants