Skip to content

bug/AB#81838_Adding-a-new-page-hides-other-pages-from-application #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions libs/ui/src/lib/sidenav/sidenav.directive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import {
SimpleChanges,
OnChanges,
Inject,
ChangeDetectorRef,
} from '@angular/core';
import { SidenavPositionTypes, SidenavTypes } from './types/sidenavs';
import { DOCUMENT } from '@angular/common';
Expand Down Expand Up @@ -62,14 +61,12 @@ export class SidenavDirective implements OnInit, OnDestroy, OnChanges {
* @param renderer Renderer2
* @param document Document
* @param overlay CDK Overlay
* @param cdr ChangeDetectorRef
*/
constructor(
public el: ElementRef,
private renderer: Renderer2,
@Inject(DOCUMENT) private document: Document,
private overlay: Overlay,
private cdr: ChangeDetectorRef
private overlay: Overlay
) {}

ngOnInit(): void {
Expand Down Expand Up @@ -163,7 +160,6 @@ export class SidenavDirective implements OnInit, OnDestroy, OnChanges {
});
this.overlayRef.updatePosition();
}
this.cdr.detectChanges();
}

/**
Expand Down
6 changes: 1 addition & 5 deletions libs/ui/src/lib/tabs/directives/tab-body-host.directive.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { CdkPortalOutlet } from '@angular/cdk/portal';
import { DOCUMENT } from '@angular/common';
import {
ChangeDetectorRef,
ComponentFactoryResolver,
Directive,
EventEmitter,
Expand Down Expand Up @@ -41,13 +40,11 @@ export class TabBodyHostDirective
* @param componentFactoryResolver Angular component factory resolver ( deprecated )
* @param viewContainerRef Angular view container reference
* @param _document document
* @param cdr ChangeDetectorRef
*/
constructor(
componentFactoryResolver: ComponentFactoryResolver,
viewContainerRef: ViewContainerRef,
@Inject(DOCUMENT) _document: any,
private cdr: ChangeDetectorRef
@Inject(DOCUMENT) _document: any
) {
super(componentFactoryResolver, viewContainerRef, _document);
}
Expand All @@ -64,7 +61,6 @@ export class TabBodyHostDirective
if (!this.hasAttached()) {
this.attach(tab.content);
}
this.cdr.detectChanges();
});
}

Expand Down
6 changes: 1 addition & 5 deletions libs/ui/src/lib/tooltip/tooltip.directive.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import {
Inject,
OnInit,
Attribute,
ChangeDetectorRef,
} from '@angular/core';
import { ShadowDomService } from '../shadow-dom/shadow-dom.service';
import { TooltipEnableBy } from './types/tooltip-enable-by-list';
Expand Down Expand Up @@ -61,15 +60,13 @@ export class TooltipDirective implements OnDestroy {
* @param elementRef Tooltip host reference
* @param renderer Angular renderer to work with DOM
* @param {ShadowDomService} shadowDomService Shadow dom service containing the current DOM host in order to correctly insert tooltips
* @param cdr ChangeDetectorRef
*/
constructor(
@Inject(DOCUMENT) private document: Document,
@Attribute('tooltipEnableBy') public enableBy: TooltipEnableBy,
public elementRef: ElementRef,
private renderer: Renderer2,
shadowDomService: ShadowDomService,
private cdr: ChangeDetectorRef
shadowDomService: ShadowDomService
) {
this.currentHost = shadowDomService.isShadowRoot
? shadowDomService.currentHost
Expand Down Expand Up @@ -109,7 +106,6 @@ export class TooltipDirective implements OnDestroy {
if (this.currentHost.contains(this.elToolTip)) {
this.renderer.removeChild(this.currentHost, this.elToolTip);
}
this.cdr.detectChanges();
}

/**
Expand Down