Feat/ab#74663 open settings when creating new widget #1843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estelafs
reviewed
Sep 18, 2023
There was a problem hiding this comment.
Everything is working as expected. @AntoineRelief but this way it is impossible to create empty/unconfigured charts, grids and maps (summary cards can be saved without data sources and text widgets with the default "Enter a context" text), is this correct right? It was not clear from the ticket description
| @@ -177,8 +177,37 @@ export class SafeWidgetGridComponent | |||
| * | |||
| * @param e new widget. | |||
There was a problem hiding this comment.
@RenzoPrats
Please also check the comments left on methods when doing such important changes.
There, for example, the comment of the method is not valid anymore, because it's not only about emitting an event, it's about opening the settings
| .subscribe((value: any) => { | ||
| // Should save the value, and so, add the widget to the grid | ||
| if (value) { | ||
| this.add.emit({ |
There was a problem hiding this comment.
@RenzoPrats @estelafs
previous solution of first doing "add" then "edit" with a timeout was bad, because you can't, in any case, do that from the front-end, as this way, it CAN'T know if the operation was indeed successful or not
this way, you create the widget with all the correct settings, in a single call
AntoineRelief
deleted the
feat/AB#74663_open_settings_when_creating_new_widget
branch
AntoineRelief
pushed a commit
that referenced
this pull request
Sep 21, 2023
…ntend@v2.0.10...v2.1.0) (2023-09-21) ### Features CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets documentation.json error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets add tooltip when widget grid text overflows ([44850ed](ReliefApplications@44850ed)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets documentation.json error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets automatically open widget settings on addition ([#1843](https://github.com/ReliefApplications/oort-frontend/issues/1843)) ([6ab4174](ReliefApplications@6ab4174)), closes [feat/AB#74663](https://github.com/feat/AB/issues/74663) ### Performance Improvements CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets documentation.json error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets update apollo versions ([#1771](https://github.com/ReliefApplications/oort-frontend/issues/1771)) ([#1810](https://github.com/ReliefApplications/oort-frontend/issues/1810)) ([30180a1](ReliefApplications@30180a1))
AntoineRelief
pushed a commit
that referenced
this pull request
Oct 4, 2023
…tions/oort-frontend@v2.2.0-beta.1...v2.2.0-beta.2) (2023-10-04) ### Bug Fixes CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets access to the platform could fail due to login not completed ([#1854](https://github.com/ReliefApplications/oort-frontend/issues/1854)) ([10ba120](ReliefApplications@10ba120)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets aggregation filters only appling after saving twice ([#1829](https://github.com/ReliefApplications/oort-frontend/issues/1829)) ([3dd8bd4](ReliefApplications@3dd8bd4)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets build not working ([3ed5f5b](ReliefApplications@3ed5f5b)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets context filter not loaded in front-office ([28d39fa](ReliefApplications@28d39fa)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets custom form variables not reused when creating multiple records from same view ([#1838](https://github.com/ReliefApplications/oort-frontend/issues/1838)) ([8fb2564](ReliefApplications@8fb2564)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets dashboard filter not working in summary cards dashboard ([#1908](https://github.com/ReliefApplications/oort-frontend/issues/1908)) ([b0f3da0](ReliefApplications@b0f3da0)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets date could not be cleared if opening a record with value in field ([2c0d047](ReliefApplications@2c0d047)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets delete min-width of question in order to match current sidebar width ([#1912](https://github.com/ReliefApplications/oort-frontend/issues/1912)) ([697eb83](ReliefApplications@697eb83)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets few issues with layer styling ([baf115b](ReliefApplications@baf115b)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets infinite redirection when trying to open a contextual page ([#1903](https://github.com/ReliefApplications/oort-frontend/issues/1903)) ([3dbec90](ReliefApplications@3dbec90)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets layers get duplicated when changing dashboard filter value ([#1876](https://github.com/ReliefApplications/oort-frontend/issues/1876)) ([5decf06](ReliefApplications@5decf06)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets menu items text and buttons overlapping in firefox ([#1834](https://github.com/ReliefApplications/oort-frontend/issues/1834)) ([47532f9](ReliefApplications@47532f9)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets only get visible fields when exporting grid data [#35940](https://github.com/ReliefApplications/oort-frontend/issues/35940) ([#1807](https://github.com/ReliefApplications/oort-frontend/issues/1807)) ([ce008da](ReliefApplications@ce008da)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets remove expand option for map widgets ([#1877](https://github.com/ReliefApplications/oort-frontend/issues/1877)) ([bfd1b2c](ReliefApplications@bfd1b2c)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets remove format filter method in grid, that could cause some date issues ([df3ee09](ReliefApplications@df3ee09)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets selected records in text widget would not appear when opening settings ([#1901](https://github.com/ReliefApplications/oort-frontend/issues/1901)) ([93a9af6](ReliefApplications@93a9af6)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets tagbox in surveyjs would not work in some cases ([f6cba5a](ReliefApplications@f6cba5a)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets toggle would not correctly indicate touch events ([43cba1d](ReliefApplications@43cba1d)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets unable to invite new users, UI was broken ([#1902](https://github.com/ReliefApplications/oort-frontend/issues/1902)) ([a0a5eb6](ReliefApplications@a0a5eb6)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets use flex-end and default margin false to the date field in the tab-filter component in order to align the element to the rest of the y axis ([#1809](https://github.com/ReliefApplications/oort-frontend/issues/1809)) ([d8b10c5](ReliefApplications@d8b10c5)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets web widgets would not build ([#1886](https://github.com/ReliefApplications/oort-frontend/issues/1886)) ([73c1bc4](ReliefApplications@73c1bc4)) ### Features CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets ability to archive and restore application pages ([#1505](https://github.com/ReliefApplications/oort-frontend/issues/1505)) ([8c38ccf](ReliefApplications@8c38ccf)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets add more options to cluster layers ([#1906](https://github.com/ReliefApplications/oort-frontend/issues/1906)) ([c5e2d14](ReliefApplications@c5e2d14)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets add tooltip when widget grid text overflows ([44850ed](ReliefApplications@44850ed)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets automatically open widget settings on addition ([#1843](https://github.com/ReliefApplications/oort-frontend/issues/1843)) ([6ab4174](ReliefApplications@6ab4174)), closes [feat/AB#74663](https://github.com/feat/AB/issues/74663) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets can now edit page / step 's icon ([5a58854](ReliefApplications@5a58854)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets can now query historical data ([#1873](https://github.com/ReliefApplications/oort-frontend/issues/1873)) ([7627df4](ReliefApplications@7627df4)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets can now use infinite aggregations ([4379df2](ReliefApplications@4379df2)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets display matrix questions in grid / text / summary card widgets ([#1350](https://github.com/ReliefApplications/oort-frontend/issues/1350)) ([25dc2df](ReliefApplications@25dc2df)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets inline edition of reference data ([4dfa2b3](ReliefApplications@4dfa2b3)) ### Performance Improvements CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets **bundle:** remove useless kendo styles imports ([#1882](https://github.com/ReliefApplications/oort-frontend/issues/1882)) ([70b74fc](ReliefApplications@70b74fc)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets update apollo versions ([#1771](https://github.com/ReliefApplications/oort-frontend/issues/1771)) ([#1810](https://github.com/ReliefApplications/oort-frontend/issues/1810)) ([30180a1](ReliefApplications@30180a1)) CHANGELOG CHANGELOG.md CI LICENSE README.md TODO.md apps assets error_pages jest-shim.ts jest.config.ts jest.preset.js libs makefile migration-storybook.log node_modules nx.json package-lock.json package.json release.config.js tailwind.config.js tools tsconfig.base.json widgets update surveyjs package, to use Angular version, and drop knockout ([#1763](https://github.com/ReliefApplications/oort-frontend/issues/1763)) ([73f29f8](ReliefApplications@73f29f8))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved user flow when adding a new widget from dashboard, now it opens the settings.
Useful links
User story
Improvement ticket for implementation
Type of change
How Has This Been Tested?
It has been tested creating new widgets of all types and testing if after it's created it opens the settings and when saving the settings is correctly applied to the widget.
Screenshots
Checklist:
( * == Mandatory )