Open
Conversation
15 tasks
estelafs
suggested changes
Nov 21, 2023
Contributor
estelafs
left a comment
There was a problem hiding this comment.
@MwanPygmay While checking the date type issue on the front end, you could also combine here in the backend the cases of 'numeric', 'date' and 'time' fields since they have the same code and we can just send the data string to the frontend once since datepipe already converts it to date when necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Wrote query to get fields details. Query should be optimised: the max records that we query is 5. Sort and limit should behave well and avoid sorting the whole records (see documentation below). Would be good to test on a database with lots of records. On small database it is instant.
Useful links
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
See front, acquirement of data went well. Main problem is often not providing a resource id.
Screenshots
See front.
Checklist:
( * == Mandatory )