Add code-review and submit skills, stabilize plugin#32
Open
Add code-review and submit skills, stabilize plugin#32
Conversation
Design for a two-layer AI-assisted review system: local submit flow (/shipwright:submit) and CI automation. Covers the code-review skill, PR description generation, and GitHub Action workflow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove the skip-review override from the submit command design. Review always runs; developers can still proceed past blockers after seeing results. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Add implementation plan with 6 tasks: code-review skill, submit command, CI workflow, and smoke test updates - Update design doc: fix loop is developer-driven (select which findings to auto-fix) instead of automatic Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…atch CI review component builds on existing dev-review-agent GitHub Action rather than a new implementation. The code-review skill in Shipwright is the single source of truth, consumed by dev-review-agent as a git-based npm dependency pinned to a version tag. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
15-task plan across 4 phases with TDD, exact file paths, and complete code for both Shipwright and dev-review-agent repos. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…on plan Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Mirrors the independent scoring rationale — isolation prevents cross-contamination between passes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Update validate-commands.sh for renamed command files (dropped shipwright- prefix) - Remove stale attribution check from internal skills loop (moved to THIRD_PARTY_NOTICES) - Add brownfield-analysis to ORIGINAL_SKILLS (attribution centralized) - Fix stale shipwright-beta reference in promote.md Found by running the code-review skill during submit flow. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
larf311
changed the title
Contributor
Author
|
I'm not sure about checking in the plans. Seems messy but I left them for this one. Let me know if you want me to remove them. Also, I'm pretty unsure about including the pre-submit review. I'll probably remove that but I left it b/c it was interesting for now. Definitely lots of room for improving the prompt but I think it's a good start. |
Collaborator
|
I like the PR Description a lot. I agree, we may want to remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds two new user-facing skills (
code-review,submit) and completes several housekeeping changes: promoting the plugin from beta to stable, reorganizing internals, centralizing attribution, and adding a rootpackage.jsonfor npm installability.Why
The code-review skill is the shared review logic for both local (
/submit) and CI (dev-review-agent) workflows — a two-layer AI-assisted review system designed indocs/plans/2026-02-26-code-review-design.md. The submit skill is the local developer flow from "done coding" to "draft PR ready." The organizational changes (internal/ directory, command renames, attribution consolidation) reduce user-facing surface area and token waste.How to review
skills/code-review/SKILL.mdandskills/submit/SKILL.mdare the core additions. Review the three-pass review structure, confidence scoring design, and submit flow steps.tests/smoke/validate-*.shwere updated for the new skills, the internal/user-facing split, and centralized attribution. All 4 suites pass (92/92 checks).internal/, renamed commands to dropshipwright-prefix, and consolidated attribution intoTHIRD_PARTY_NOTICES. These are mostly file moves.Pre-submit review
Local code-review skill (3-pass with separate agents) found 3 blockers and 1 warning, all pre-existing on the branch:
validate-commands.shnot updated for renamed command files — fixedTHIRD_PARTY_NOTICES— fixedbrownfield-analysismissing fromORIGINAL_SKILLS— fixedpromote.mdstaleshipwright-betareference — fixed