Fix for rai-8229 issue #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkins
approved these changes
Dec 13, 2022
Contributor
|
doh I approved but just realized this fails unclearly when provision fails, we need to make a modification to fail clearly when provision fails |
Contributor
Author
sorry I was in hurry to merge the PR 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for
with_engineto pull until state isPROVISIONEDorPROVISION_FAILEDengine is no longer required when creating a database
create_databaseoverwrite option is deprecatedthis should fix this issue: https://relationalai.atlassian.net/browse/RAI-8229