Add missing cancel_transaction function #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NHDaly
reviewed
Oct 3, 2022
Comment on lines
+651
to
+654
| function cancel_transaction(ctx::Context, id::AbstractString; kw...) | ||
| path = PATH_ASYNC_TRANSACTIONS * "/$id/cancel" | ||
| return _post(ctx, path) | ||
| end |
Member
There was a problem hiding this comment.
Can you please add a unit test for this? Probably it doesn't need to be an integration test; just a unit test that confirms that the correct path is hit with a POST request?
Thank you!
NHDaly
approved these changes
Oct 3, 2022
Member
NHDaly
left a comment
NHDaly
left a comment
There was a problem hiding this comment.
LGTM other than request for tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to
cancel_transactionfunctionalityCloses #68