Gracefully handle crashed / cancelled txns #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Assuming the tests pass, I'm going to merge this without review, to unblock the benchmarking issue that originally surfaced this error. |
Member
Author
|
... this didn't seem to help locally. I'll have another look tomorrow, but on reflection this can probably wait for review. Sorry I was rushing 😊 |
Member
Author
|
Feel free to merge yourself if you give an approval tomorrow morning! |
vilterp
approved these changes
Sep 1, 2022
ary
approved these changes
Sep 1, 2022
Member
Author
|
Thanks everyone. I think i've figured out why this wasn't working. it was throwing a TaskFailedException because of the And now i've added a test, which confirms that this is finally fixed (that's how i confirmed it wasn't working). |
NRHelmi
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/RelationalAI/rai-sdk-issues/issues/70 for the Julia SDK.
We currently throw a 404 error if the transaction is cancelled or crashes before executing. This will be fixed in future versions of relationalai infra, but in the meantime, this workaround swallows such errors.