Add readtimeouts for get on transation metadata, problems, and results #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NHDaly
approved these changes
Aug 31, 2023
Member
NHDaly
left a comment
NHDaly
left a comment
There was a problem hiding this comment.
LGTM, thanks Jacob. In the future, we might want to consider setting this for all SDK operations, or maybe only some, but probably more than these.
I think probably all SDK functions except maybe create transaction would want this.
Member
|
Maybe it's as simple as "all GET" calls should set this, and all PUT calls don't want to set a timeout? |
NHDaly
referenced
this pull request
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.