Don't use Pkg to compute project-version. #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NHDaly
force-pushed
the
nhd-fix-project_version
branch
from
ad5ff68 to
5d3c44e
Compare
This feature from Pkg is apparently "experimental" and not well supported, so it's safer to just read from the TOML file ourselves. Also, TOML is a much smaller dependency than Pkg.
NHDaly
force-pushed
the
nhd-fix-project_version
branch
from
5d3c44e to
c82df24
Compare
msagarpatel
reviewed
May 26, 2023
msagarpatel
approved these changes
May 26, 2023
Member
msagarpatel
left a comment
msagarpatel
left a comment
There was a problem hiding this comment.
If the type of the version number is not a problem, LGTM. Thanks for tracking this down, @NHDaly!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature from Pkg is apparently "experimental" and not well supported, so it's safer to just read from the TOML file ourselves.
Also, TOML is a much smaller dependency than Pkg.