Skip to content

Conversation

@msagarpatel
Copy link
Member

In interactive use, this struct can print a lot of information that the user cannot directly interpret. This PR defines a pretty printer to avoid the wall of text.

In interactive use, this struct can print a lot of information that the
user cannot directly interpret. This PR defines a pretty printer to
avoid the wall of text.
@msagarpatel msagarpatel requested review from NHDaly and NRHelmi April 27, 2023 14:00
@bergel
Copy link
Contributor

bergel commented Apr 27, 2023

Before the PR, I had
Screenshot 2023-04-27 at 16 38 09
With this PR I have:
Screenshot 2023-04-27 at 16 38 19

All looks good!

@bergel bergel self-requested a review April 27, 2023 14:39
Copy link
Contributor

@bergel bergel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the comments

Co-authored-by: Nathan Daly <nathan.daly@relational.ai>
@msagarpatel msagarpatel merged commit 93395db into main Apr 27, 2023
@msagarpatel msagarpatel deleted the sp-metadata-pretty-printer branch April 27, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants