Skip to content

Fix incorrect return of DateTime object in _translate_start_time_ns #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2023
Merged

Fix incorrect return of DateTime object in _translate_start_time_ns #103

merged 2 commits into from
Jan 13, 2023

Conversation

@nantiamak
Copy link
Contributor

@nantiamak nantiamak commented Jan 13, 2023 •
edited by atlassian bot
Loading

@nantiamak nantiamak requested review from NHDaly and quinnj January 13, 2023 12:55
@quinnj quinnj merged commit 59d6e20 into main Jan 13, 2023
@quinnj quinnj deleted the nm-fix-_transaction_start_time_ns branch January 13, 2023 15:15
@nantiamak
Copy link
Contributor Author

nantiamak commented Jan 13, 2023

Thanks @quinnj!

@nantiamak
Copy link
Contributor Author

nantiamak commented Jan 13, 2023

@NHDaly FYI

@NHDaly
Copy link
Member

NHDaly commented Jan 13, 2023

Thanks @nantiamak! :) I'll push up the time_ns change separately

@NHDaly NHDaly mentioned this pull request Jan 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NHDaly NHDaly Awaiting requested review from NHDaly

1 more reviewer

@quinnj quinnj quinnj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nantiamak @NHDaly @quinnj