Skip to content

Don't mutate user-given headers #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2023
Merged

Don't mutate user-given headers #101

merged 1 commit into from
Jan 11, 2023

Conversation

@nickrobinson251
Copy link
Member

@nickrobinson251 nickrobinson251 commented Jan 11, 2023

quinnj
quinnj approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@quinnj quinnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nickrobinson251!

@nickrobinson251 nickrobinson251 merged commit b4bd64a into main Jan 11, 2023
@nickrobinson251 nickrobinson251 deleted the npr-rai-7063 branch January 11, 2023 19:57
NHDaly
NHDaly reviewed Jan 12, 2023
View reviewed changes
Copy link
Member

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a perfect PR. thanks nick! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NHDaly NHDaly NHDaly left review comments

@nantiamak nantiamak Awaiting requested review from nantiamak

+1 more reviewer

@quinnj quinnj quinnj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nickrobinson251 @NHDaly @quinnj