Skip to content

Conversation

kpamnany
Copy link
Collaborator

@kpamnany kpamnany commented Jul 30, 2025

PR Description

The code implements a semaphore-based system to limit concurrent AOT compilation processes using the JC_PAR_PRECOMP_SEM environment variable. It includes proper RAII cleanup, signal-safe waiting, and assumes the semaphore is pre-created by a parent process to control compilation parallelism. This is done to limit the amount of processes that can enter the memory intensive part of the AOT compilation.

Checklist

Requirements for merging:

Copy link
Collaborator Author

@kpamnany kpamnany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice and simple, barring a few comments.

@bunjj bunjj self-assigned this Jul 31, 2025
@bunjj bunjj force-pushed the ib-lock-aot-compilation branch from de28c00 to 54dec94 Compare July 31, 2025 09:00
@bunjj bunjj changed the title Ib lock aot compilation Implement semaphore-based AOT compilation throttling Jul 31, 2025
@bunjj bunjj requested a review from NHDaly July 31, 2025 09:02
Copy link
Collaborator Author

@kpamnany kpamnany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Clean and compact patch. I can't approve because I opened the PR, but you can approve and merge this @bunjj. 👍

@bunjj bunjj self-requested a review July 31, 2025 14:20
Copy link
Member

@NHDaly NHDaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left a comment about changing the name of the ENV variable to be more verbose.

@bunjj bunjj force-pushed the ib-lock-aot-compilation branch from 54dec94 to 0e5b231 Compare August 4, 2025 07:36
@bunjj bunjj merged commit 0bd16ac into v1.10.2+RAI Aug 4, 2025
1 check passed
@bunjj bunjj deleted the ib-lock-aot-compilation branch August 4, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants