Don't request optional parquet indexes as required#57
Merged
Conversation
gbrgr
approved these changes
Feb 23, 2026
gbrgr
pushed a commit
to RelationalAI/RustyIceberg.jl
that referenced
this pull request
Feb 25, 2026
Propagate the fix RelationalAI/iceberg-rust#57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use "legacy" way to pass PageIndexPolicy enum from bool. And from bool, it's either required or skipped. But there's a third variant - optional. Here rather than refactoring bool to enum all the way from table scan to arrow reader, I'm just defaulting to convert
truetoPageIndexPolicy::Optional, which seems ok, since I don't think we have a use-case where we'd want this as a required (i.e. forcing it to fail).