Skip to content

Fix/GitHub stars return type #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ManukMinasyan merged 2 commits into from
Jan 20, 2026
+9 −6
Merged

Fix/GitHub stars return type #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2767bf0
test: add test for cached string value edge case
ManukMinasyan Jan 20, 2026
ab2e1d2
chore: remove coverage report from default test runs
ManukMinasyan Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions phpunit.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,6 @@
<file>app/Providers/AppServiceProvider.php</file>
</exclude>
</source>
<coverage>
<report>
<html outputDirectory="coverage-html" lowUpperBound="50" highLowerBound="80"/>
<clover outputFile="coverage.xml"/>
</report>
</coverage>
<php>
<env name="APP_ENV" value="testing"/>
<env name="APP_MAINTENANCE_DRIVER" value="file"/>
Expand Down
9 changes: 9 additions & 0 deletions tests/Unit/Services/GitHubServiceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,3 +113,12 @@
// Should be abbreviated
expect($result)->toBe('12.5K');
});

it('returns int even when cache contains string value', function () {
// Simulate cache containing a string (as might happen from serialization)
Cache::put('github_stars_Relaticle_relaticle', '125', now()->addMinutes(15));

$result = $this->service->getStarsCount('Relaticle', 'relaticle');

expect($result)->toBe(125)->toBeInt();
});