Add react-x/jsx-dollar rule, closes #1300
#1302
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new ESLint rule jsx-dollar that detects and suggests fixes for unnecessary dollar signs ($) before JSX expressions, which commonly occur when refactoring from template literals to JSX. The PR also updates documentation links from the main branch to jsx-dollar branch and bumps the dprint TypeScript plugin version.
- Implements a new rule that identifies
$characters immediately before JSX expression containers - Provides autofix suggestions to remove the unnecessary dollar sign
- Includes comprehensive test cases and documentation
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/plugins/eslint-plugin-react-x/src/rules/jsx-dollar.ts | New rule implementation detecting dollar signs before JSX expressions |
| packages/plugins/eslint-plugin-react-x/src/rules/jsx-dollar.spec.ts | Test cases for the new jsx-dollar rule |
| packages/plugins/eslint-plugin-react-x/src/rules/jsx-dollar.mdx | Documentation explaining the rule's purpose and usage examples |
| packages/plugins/eslint-plugin/README.md | Updated GitHub links to point to jsx-dollar branch |
| apps/website/content/docs/rules/meta.json | Added jsx-dollar to the rules navigation menu |
| dprint.json | Bumped TypeScript plugin version from 0.95.11 to 0.95.12 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information