FEAT-modin-project#6041: implement 'Series.cat' through 'CachedAccess…

…or' (modin-project#6057) Signed-off-by: Anatoly Myachev <anatoly.myachev@intel.com>
RehanSD · Apr 28, 2023 · 8817093 · 8817093
1 parent 583036a
commit 8817093
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 14 deletions.
diff --git a/modin/pandas/series.py b/modin/pandas/series.py
@@ -39,7 +39,7 @@
 from .iterator import PartitionIterator
 from .utils import from_pandas, is_scalar, _doc_binary_op, cast_function_modin2pandas
 from .accessor import CachedAccessor, SparseAccessor
-from .series_utils import StringMethods
+from .series_utils import CategoryMethods, StringMethods
 
 
 if TYPE_CHECKING:
@@ -1836,6 +1836,7 @@ def sort_values(
             result._query_compiler, inplace=inplace
         )
 
+    cat = CachedAccessor("cat", CategoryMethods)
     sparse = CachedAccessor("sparse", SparseAccessor)
     str = CachedAccessor("str", StringMethods)
 
@@ -2168,15 +2169,6 @@ def axes(self):  # noqa: RT01, D200
         """
         return [self.index]
 
-    @property
-    def cat(self):  # noqa: RT01, D200
-        """
-        Accessor object for categorical properties of the Series values.
-        """
-        from .series_utils import CategoryMethods
-
-        return CategoryMethods(self)
-
     @property
     def dt(self):  # noqa: RT01, D200
         """

diff --git a/modin/pandas/series_utils.py b/modin/pandas/series_utils.py
@@ -37,9 +37,9 @@
 
 @_inherit_docstrings(pandas.core.arrays.categorical.CategoricalAccessor)
 class CategoryMethods(ClassLogger):
-    def __init__(self, series):
-        self._series = series
-        self._query_compiler = series._query_compiler
+    def __init__(self, data):
+        self._series = data
+        self._query_compiler = data._query_compiler
 
     @pandas.util.cache_readonly
     def _Series(self):  # noqa: GL08

diff --git a/modin/pandas/test/test_api.py b/modin/pandas/test/test_api.py
@@ -266,7 +266,7 @@ def test_series_dt_api_equality():
 
 
 def test_series_cat_api_equality():
-    modin_dir = [obj for obj in dir(pd.Series().cat) if obj[0] != "_"]
+    modin_dir = [obj for obj in dir(pd.Series.cat) if obj[0] != "_"]
     pandas_dir = [obj for obj in dir(pandas.Series.cat) if obj[0] != "_"]
 
     missing_from_modin = set(pandas_dir) - set(modin_dir)