Fix rare panic during ApplePS2Controller initialization #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ApplePS2Controller's IOService publication/termination notification handler calls into the controller's workloop, but the handler was being registered before the workloop and associated command gate were created. There was a short window between registering the handler and creating the workloop and command gate where receiving a notification would dereference a NULL command gate pointer. Move the addMatchingNotification calls to after the workloop and gate are created to prevent this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ApplePS2Controller's IOService publication/termination notification handler
calls into the controller's workloop, but the handler was being registered
before the workloop and associated command gate were created. There was a
short window between registering the handler and creating the workloop and
command gate where receiving a notification would dereference a NULL command
gate pointer.
Move the addMatchingNotification calls to after the workloop and gate are
created to prevent this.