Skip to content

fix(tree-select): inconsistency Collapse all behavior with disabled item #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: v7
Choose a base branch
from
Draft

fix(tree-select): inconsistency Collapse all behavior with disabled item #987

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f5ff168
fix(tree-select): inconsistency collapse all behavior with disabled item
Nantawat-Poothong Oct 6, 2023
b90e2fe
Merge branch 'v7' into fix/tree-select-cant-collapse-all-with-all-dis…
Nantawat-Poothong Oct 9, 2023
6e1d8b9
Merge branch 'v7' into fix/tree-select-cant-collapse-all-with-all-dis…
Nantawat-Poothong Oct 10, 2023
542684a
Merge branch 'v7' into fix/tree-select-cant-collapse-all-with-all-dis…
Nantawat-Poothong Oct 27, 2023
83c5017
Merge branch 'v7' into fix/tree-select-cant-collapse-all-with-all-dis…
wsuwt Nov 20, 2023
ece722c
Merge branch 'v7' into fix/tree-select-cant-collapse-all-with-all-dis…
wsuwt Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/elements/src/tree-select/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ export class TreeSelect extends ComboBox<TreeSelectDataItem> {
const hasChildren = composer.getItemChildren(item).length;
if (hasChildren) {
this.memo.expandable += 1;
if (this.treeManager.isItemExpanded(item) && this.treeManager.isItemCheckable(item)) {
if (this.treeManager.isItemExpanded(item)) {
this.memo.expanded += 1;
}
}
Expand Down