Feature/integrate datetime field update unit test #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of https://github.com/Refinitiv/refinitiv-ui into feat/new-integrate-datetime-picker-with-datetime-field
… of https://github.com/Refinitiv/refinitiv-ui into test/integrate-datetime-field-update-unit-test
… of https://github.com/Refinitiv/refinitiv-ui into feature/integrate-datetime-field-update-unit-test
Deploying with
|
| Latest commit: |
c8a94c2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2acc3928.refinitiv-ui.pages.dev |
| Branch Preview URL: | https://feature-integrate-datetime-f.refinitiv-ui.pages.dev |
goremikins
reviewed
Aug 8, 2022
packages/elements/src/datetime-picker/__test__/datetime-picker.default.test.js
Show resolved
Hide resolved
packages/elements/src/datetime-picker/__test__/datetime-picker.default.test.js
Show resolved
Hide resolved
| await nextFrame(); | ||
| await nextFrame(); | ||
| await nextFrame(el); | ||
| await nextFrame(el); |
There was a problem hiding this comment.
Here and in other places. I think these multiple nextFrame calls were added to accommodate IE11. Please double check if you still need them.
There was a problem hiding this comment.
Updated. It still need to call nextFrame one time after updating the views.
packages/elements/src/datetime-picker/__test__/datetime-picker.value.test.js
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed.
|
goremikins
approved these changes
Aug 10, 2022
goremikins
merged commit a1b5cdd
into
feat/new-integrate-datetime-picker-with-datetime-field
goremikins
deleted the
feature/integrate-datetime-field-update-unit-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update unit test.