Skip to content

Refactor datetime-picker #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Aug 19, 2022
Merged

Refactor datetime-picker #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
da54a0b
feat(datetime-field): make locale function public
goremikins Jul 25, 2022
6da917e
fix(datetime-picker): incorrect format detection in some scenarios
goremikins Jul 26, 2022
9326107
fix(datetime-picker): circular function call
goremikins Jul 26, 2022
6c61974
style(datetime-picker): use part button
goremikins Jul 27, 2022
6d21f30
fix(datetime-picker): setting incorrect value throws an error
goremikins Jul 29, 2022
1e59bd2
fix(datetime-picker): filter out invalid type values
goremikins Aug 2, 2022
48a3eac
fix(datetime-picker): remove unused arguments
goremikins Aug 2, 2022
99ea3d1
fix(datetime-picker): remove unused import
goremikins Aug 2, 2022
9087025
fix(datetime-picker): view property is not reset to empty string when…
goremikins Aug 4, 2022
a8a913d
fix(datetime-picker): no closing template
goremikins Aug 4, 2022
3f70745
fix(datetime-picker): incorrect view filtering
goremikins Aug 4, 2022
a1b5cdd
Feature/integrate datetime field update unit test (#424)
Sarin-Udompanish Aug 10, 2022
ca41c89
feat(utils): add format checks to Locale object
goremikins Aug 10, 2022
56c7fe9
feat(datetime-picker): remove duplex consecutive mode
goremikins Aug 11, 2022
9eb3feb
test(datetime-picker): remove duplex consecutive mode
goremikins Aug 11, 2022
c7cdfda
feat(datetime-picker): independent From & To calendars in duplex/rang…
goremikins Aug 15, 2022
d194140
feat(datetime-picker): default views in duplex mode should be the same
goremikins Aug 16, 2022
28fae2f
fix(datetime-picker): incorrect view-changed event
goremikins Aug 17, 2022
c1f4483
docs(datetime-picker): update documentation
Sarin-Udompanish Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
312 changes: 95 additions & 217 deletions documents/src/pages/elements/datetime-picker.md
View file
Open in desktop

Large diffs are not rendered by default.

162 changes: 81 additions & 81 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 17 additions & 4 deletions packages/elemental-theme/src/custom-elements/ef-datetime-picker.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,23 @@
}
// #endregion

padding: 0;

[part~=button] {
height: 100%;
width: @button-height;
display: flex;
justify-content: center;
align-items: center;
flex: none;
padding: 0;
margin: 0;
border: 0;
background: none;
color: inherit;
font-size: inherit;
}

[part=calendar] {
width: @calendar-width;
padding: 0 calc((@input-width - @calendar-width) / 2);
Expand All @@ -57,10 +74,6 @@
color: inherit;
}

[part='icon'] {
color: @control-text-color;
}

[part=input-separator] {
line-height: @control-height;
background: @global-text-color;
Expand Down
Loading