Fix WORK strides in P?LARZ ?AXPY calls#161
Merged
langou merged 1 commit intoMay 5, 2026
Merged
Conversation
Fix incorrect BLAS vector increments in `P?LARZ` left-side `?AXPY` calls.
`WORK(IPW)` stores a contiguous local work vector, so the `?AXPY` increment must be `1`. The previous calls used `MAX(1,NQC2)`, which is appropriate as a leading dimension for matrix-style BLACS/LAPACK calls but incorrect as a BLAS vector stride.
- Updated left-side `?AXPY` calls that read/write `WORK` or `WORK(IPW)` to use increment `1`.
- Kept `C` increments unchanged:
- `LDC` when traversing a row of local `C`
- `1` when traversing a column of local `C`
For comparison, LAPACK's DLARZ uses INCX=1 in the analogous DAXPY:
DAXPY( N, -TAU, WORK, 1, C, LDC )
The value MAX(1, NQC2) does belong nearby — it is the legitimate LDA of the surrounding DLASET / DGSUM2D matrix-shaped calls. The bug looks like a copy-paste of that LDA into the DAXPY's stride slot.
The previous stride could skip elements in `WORK` and potentially access out-of-bounds memory when `NQC2 > 1`. This fixes the local Householder update path without changing the algorithm.
langou
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect BLAS vector increments in
P?LARZleft-side?AXPYcalls.WORK(IPW)stores a contiguous local work vector, so the?AXPYincrement must be1. The previous calls usedMAX(1,NQC2), which is appropriate as a leading dimension for matrix-style BLACS/LAPACK calls but incorrect as a BLAS vector stride.?AXPYcalls that read/writeWORKorWORK(IPW)to use increment1.Cincrements unchanged:LDCwhen traversing a row of localC1when traversing a column of localCFor comparison, LAPACK's DLARZ uses INCX=1 in the analogous DAXPY:
The value MAX(1, NQC2) does belong nearby — it is the legitimate LDA of the surrounding DLASET / DGSUM2D matrix-shaped calls. The bug looks like a copy-paste of that LDA into the DAXPY's stride slot.
The previous stride could skip elements in
WORKand potentially access out-of-bounds memory whenNQC2 > 1. This fixes the local Householder update path without changing the algorithm.