FIX: Revert the conjugation removal in zunbdb3#1196
Merged
Conversation
Contributor
Author
|
I'm not sure about this change. I'll investigate a bit more and reopen after validating. |
langou
approved these changes
Mar 24, 2026
Contributor
langou
left a comment
langou
left a comment
There was a problem hiding this comment.
Crazy. Thanks for spotting this.
nakatamaho
added a commit
to nakatamaho/mplapack
that referenced
this pull request
Apr 14, 2026
Add the upstream ZUNBDB3 fix that conjugates the X21 row before generating and applying the right Householder reflector. The row is already conjugated again afterward, so this makes the reflector operate with the expected complex vector convention while preserving the stored data layout. Register the LAPACK 3.12.1 patch, include it in EXTRA_DIST, and mirror the fix in the generated Cunbdb3 reference implementation. Enable the LAPACK 3.12.1 CSD input patch in the fable test patch flow, which adds small M/P/Q edge cases to csd.in. see also: Reference-LAPACK/lapack#1232 Reference-LAPACK/lapack#1196
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the C translation work I found out a particular test case failing for both semicolon-lapack, and Reference LAPACK however passing with OpenBLAS, since it did not have the latest additions. Further investigation shows that a crucial step was accidentally removed.
In particular, there was an explicit conjugation step that is removed in #1020, causing certain tests fail (
zckcsd.ffor CS decomposition). This PR fixes this removal. The single precision is not affected hence left untouched.Checklist