Skip to content

Comments

Music Quiz Game#210

Merged
DxsSucuk merged 36 commits intomasterfrom
feature/music-quiz
Jan 27, 2023
Merged

Music Quiz Game#210
DxsSucuk merged 36 commits intomasterfrom
feature/music-quiz

Conversation

@DxsSucuk
Copy link
Member

Pull Request Etiquette

Changes

  • Internal code
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

This PR adds another feature that MEE6 has, which is the Game called "Music Quiz" which allows you to hear songs for 10 seconds and then start to guess them!

@DxsSucuk DxsSucuk mentioned this pull request Dec 12, 2022
23 tasks
@DxsSucuk
Copy link
Member Author

Still needs alot of work, for example a voice (either an SAM-Model voice or a voice actor paid to voice) which counts down and says various kind of stuff.

It also needs alot of documentation.

@DxsSucuk DxsSucuk self-assigned this Dec 12, 2022
@DxsSucuk DxsSucuk added feature A new feature p2 Medium priority. labels Dec 12, 2022
@DxsSucuk DxsSucuk modified the milestones: 2.x.x, 2.2.0 Dec 12, 2022
@DxsSucuk DxsSucuk marked this pull request as draft January 12, 2023 07:53
@DxsSucuk DxsSucuk added p1 High priority. and removed p2 Medium priority. labels Jan 12, 2023
@DxsSucuk
Copy link
Member Author

We would require to use an third-party lib that uses the youtube website instead of their public api, since these API-Limits are strict. (Only about 10 to 100 video searches per day)

@DxsSucuk
Copy link
Member Author

Well I dont wanna search years for a third party that made it so I did it lol ->
#252

# Conflicts:
#	languages/en-GB.yml
#	src/main/java/de/presti/ree6/utils/apis/YouTubeAPIHandler.java
@DxsSucuk
Copy link
Member Author

After texting almost everything works!
The only thing we will need is to block the songinfo command, make the timer actually work and only show 10 seconds of the song. Other then this we need abit more of testing and checking for Issue then it should be ready for release!

@DxsSucuk DxsSucuk marked this pull request as ready for review January 27, 2023 23:19
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
6.5% 6.5% Duplication

@DxsSucuk
Copy link
Member Author

Everything looks fine and seems to work!

The Idea of blocking the songinfo command has been thrown away, it could cause Issues such as that the command doesn't work at all anymore. And I would rather allow people to cheat in the minigame then kill the function itself.

@DxsSucuk DxsSucuk merged commit 853137b into master Jan 27, 2023
@DxsSucuk DxsSucuk deleted the feature/music-quiz branch January 27, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature A new feature p1 High priority.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant