Skip to content

Add trim and AOT compatibility for release build scanner usage #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Add trim and AOT compatibility for release build scanner usage #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b661ec6
Initial plan
Copilot Oct 25, 2025
e05c28f
Add trimming safety attributes to handlers and controls
Copilot Oct 25, 2025
f11462e
Add troubleshooting section for trimming/linker issues
Copilot Oct 25, 2025
7367448
Remove version placeholder from README
Copilot Oct 25, 2025
c3e0a3e
Fix: Move DynamicDependency attributes from classes to constructors
Copilot Oct 25, 2025
049e444
Merge branch 'main' into copilot/fix-app-crash-on-scanner
jfversluis Dec 18, 2025
75f5e91
Add DynamicDependency for MapVisibility method to maintain trimming s…
Copilot Dec 18, 2025
a9dae97
Add IsAotCompatible=true to indicate AOT compatibility
Copilot Dec 19, 2025
fd84fa2
Remove redundant EnableTrimAnalyzer property
Copilot Dec 19, 2025
8dac80a
Remove redundant DynamicDependency attributes from HostBuilderExtensions
Copilot Dec 19, 2025
565c7ea
Add DynamicallyAccessedMembers attribute to TBarcodeReader generic pa…
Copilot Dec 19, 2025
8442df2
Refine trim and AOT compatibility
jfversluis Jun 12, 2026
cd97111
Prune trim compatibility diff
jfversluis Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,3 +192,9 @@ If you need to encode international characters (e.g., Chinese, Japanese, Arabic,
```

The `CharacterSet` property is not set by default, which lets the barcode encoder use its native encoding. This avoids adding ECI (Extended Channel Interpretation) headers that some barcode scanners may not support. Common values include "UTF-8", "ISO-8859-1", "Shift_JIS", etc., depending on your barcode format requirements.

## Trimming and AOT

ZXing.Net.Maui and ZXing.Net.Maui.Controls declare AOT compatibility and are validated with the .NET trim/AOT analyzers. Normal usage through `UseBarcodeReader()` should not require linker or trimmer exceptions.

If you register a custom barcode reader with `UseBarcodeReader<TBarcodeReader>()`, make sure the implementation has public constructors that `Microsoft.Extensions.DependencyInjection` can activate.
4 changes: 3 additions & 1 deletion ZXing.Net.MAUI.Controls/HostBuilderExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
using Microsoft.Maui;
using System;
using System.Collections.Generic;
using System.Diagnostics.CodeAnalysis;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
Expand All @@ -48,7 +49,8 @@ public static MauiAppBuilder UseBarcodeReader(this MauiAppBuilder builder)
return builder;
}

public static MauiAppBuilder UseBarcodeReader<TBarcodeReader>(this MauiAppBuilder builder) where TBarcodeReader : class, Readers.IBarcodeReader
public static MauiAppBuilder UseBarcodeReader<[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors)] TBarcodeReader>(this MauiAppBuilder builder)
where TBarcodeReader : class, Readers.IBarcodeReader
{
builder.ConfigureMauiHandlers(handlers =>
{
Expand Down
4 changes: 3 additions & 1 deletion ZXing.Net.MAUI.Controls/ZXing.Net.MAUI.Controls.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@
<DebugType>portable</DebugType>
<OutputType>Library</OutputType>
<PackageReadmeFile>README.md</PackageReadmeFile>
</PropertyGroup>
<IsAotCompatible>true</IsAotCompatible>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="ZXing.Net" Version="0.16.11" />
</ItemGroup>
Expand Down
4 changes: 3 additions & 1 deletion ZXing.Net.MAUI/ZXing.Net.MAUI.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@
<DebugType>portable</DebugType>
<IsPackable>true</IsPackable>
<PackageReadmeFile>README.md</PackageReadmeFile>
</PropertyGroup>
<IsAotCompatible>true</IsAotCompatible>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>
<ItemGroup Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'android'">
<PackageReference Include="Xamarin.AndroidX.Camera.Camera2" Version="1.4.2.3" />
<PackageReference Include="Xamarin.AndroidX.Camera.Lifecycle" Version="1.4.2.3" />
Expand Down
Loading