feat: add support parameters on success failure actions by DmitryAnansky · Pull Request #3160 · Redocly/redocly-cli

DmitryAnansky · 2026-09-29T12:16:19Z

What/Why/How?

Added support for the Arazzo 1.1.0 parameters field of success and failure actions to the respect command.
When an action references a workflow with workflowId, its parameters are passed to that workflow as inputs.

Reference

Closes: #2735

Testing

Screenshots (optional)

Check yourself

This PR follows the contributing guide
All new/updated code is covered by tests
Core code changed? - Tested with other Redocly products (internal contributions only)
New package installed? - Tested in different environments (browser/node)
Documentation update has been considered

Security

The security impact of the change has been considered
Code follows company security practices and guidelines

changeset-bot · 2026-09-29T12:16:25Z

🦋 Changeset detected

Latest commit: 1f2cbd7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages

Name	Type
@redocly/openapi-core	Minor
@redocly/cli	Minor
@redocly/respect-core	Minor
@redocly/client-generator	Patch
@redocly/recheck	Minor
@redocly/reunite-integration	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2026-09-29T12:19:00Z

Performance Benchmark (Lower is Faster)

CLI Version	Bundle	Lint	Check Config
cli-latest	▓ 1.00x (Fastest)	▓ 1.00x (Fastest)	▓ 1.00x (Fastest)
cli-next	▓ 1.01x ± 0.01	▓ 1.00x ± 0.01	▓ 1.00x ± 0.01

github-actions · 2026-09-29T12:19:46Z

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	83.46% (🎯 79%)	20111 / 24095
🔵	Statements	83.08% (🎯 78%)	21730 / 26153
🔵	Functions	85.22% (🎯 82%)	3825 / 4488
🔵	Branches	75.59% (🎯 71%)	14611 / 19327

File Coverage

File	Stmts	Branches	Functions	Lines	Uncovered Lines
Changed Files
packages/core/src/rules/arazzo/parameters-unique.ts	88.88%	87.5%	100%	100%	17, 33
packages/core/src/types/arazzo1_1.ts	95.23%	88.46%	100%	95.23%	25, 159
packages/respect-core/src/arazzo-schema.ts	0%	100%	100%	0%	1-451
packages/respect-core/src/modules/context-parser/resolve-reusable-component.ts	100%	100%	100%	100%
packages/respect-core/src/modules/context-parser/resolve-reusable-object-reference.ts	100%	100%	100%	100%
packages/respect-core/src/modules/flow-runner/prepare-request.ts	89.47%	81.7%	100%	89.18%	81, 132, 194-199, 203-205, 265, 268
packages/respect-core/src/modules/flow-runner/run-step.ts	92.77%	83.8%	100%	92.63%	155, 163-165, 175-181, 310-311, 436-438, 466, 469-471, 501
packages/respect-core/src/modules/flow-runner/runner.ts	89.47%	83.87%	94.11%	90.09%	100, 204, 214-215, 230-240, 251, 277-279, 326, 440

Generated in workflow #12202 for commit 1f2cbd7 by the Vitest Coverage Report Action

Copilot

Copilot review overview

🟡 Changes recommended

Invalid parameters can be silently dropped, and exhausted retries can mutate workflow inputs without invoking the target workflow.

Review effort: Balanced
Findings: 3 · 2

Open (5)

Apply target inputs only when retry or goto workflow runs · New
Narrow caught error values instead of using any · New
Reject workflow parameters that incorrectly include an in field · New
Document workflow action parameter support for success and failure · New
Add test coverage for successful goto-workflow actions · New

What changed in this PR

Adds Arazzo 1.1 success and failure action parameters to Respect workflow execution.

Changes:

Maps action parameters to referenced workflow inputs.
Extends the Arazzo schema and documentation.
Adds unit and end-to-end failure-action coverage.

File	Description
`.changeset/respect-action-parameters.md`	Records the feature release.
`docs/@v2/commands/respect.md`	Notes partial Arazzo 1.1 support.
`packages/respect-core/src/arazzo-schema.ts`	Adds action parameter fields.
`packages/respect-core/src/modules/flow-runner/run-step.ts`	Passes parameters into target workflows.
`packages/respect-core/src/modules/__tests__/flow-runner/run-step.test.ts`	Tests failure-action inputs.
`tests/e2e/respect/action-parameters-passed-to-target-workflow/action-parameters-passed-to-target-workflow.arazzo.yaml`	Defines action parameter fixtures.
`tests/e2e/respect/action-parameters-passed-to-target-workflow/action-parameters-passed-to-target-workflow.test.ts`	Executes the new fixture.
`tests/e2e/respect/action-parameters-passed-to-target-workflow/__snapshots__/action-parameters-passed-to-target-workflow.test.ts.snap`	Captures execution output.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot

Copilot review overview

🟡 Changes recommended

Some valid reusable values are mishandled, forbidden querystring locations bypass validation, and support documentation is incomplete.

Review effort: Balanced
Findings: 1

Open (1)

Support querystring action parameters · New

Resolved since last review (5)

Reject workflow parameters that incorrectly include an in field
Narrow caught error values instead of using any
Apply target inputs only when retry or goto workflow runs
Add test coverage for successful goto-workflow actions
Document workflow action parameter support for success and failure

Previously missed (1)

In code that hasn't changed since last review

Honor falsy reusable parameter value overrides

packages/respect-core/src/modules/flow-runner/run-step.ts:331

Reusable action parameters do not honor valid falsy value overrides. This newly resolves each reusable parameter through resolveReusableComponentItem, but resolve-reusable-object-reference.ts:37 applies an override only when valueOverride is truthy; { reference: ..., value: 0 } and value: false therefore pass the component's original value to the workflow. Update that resolver to distinguish an omitted value from a falsy value and cover both scalar cases.

Copilot

Copilot review overview

🔵 Needs a closer look

Reusable action parameters silently discard valid falsy value overrides.

Review effort: Balanced
Findings: None

Resolved since last review (1)

Support querystring action parameters

Previously missed (1)

In code that hasn't changed since last review

Falsy reusable action parameter overrides are ignored

packages/respect-core/src/modules/flow-runner/run-step.ts:328

Reusable action parameters with a valid falsy override (value: 0, false, or '') lose that override here. resolveReusableObjectReference only applies overrides when valueOverride is truthy, so the component's original value is passed to the target workflow instead. Check for presence of the value field rather than truthiness, and cover a falsy override.

Copilot

Copilot review overview

🟡 Changes recommended

Invalid action parameters can be silently ignored, and falsy reusable-parameter overrides resolve incorrectly.

Review effort: Balanced
Findings: 2

Open (2)

Reject action parameters without workflowId · New
Preserve falsy reusable action parameter overrides · New

Copilot

Copilot review overview

🟡 Changes recommended

Structural validation accepts action parameter forms that the runtime ignores or rejects, and the documentation is incomplete.

Review effort: Balanced
Findings: 4

Open (4)

Require executable action type when workflowId parameters are provided · New
Reject forbidden in fields in action parameters · New
Preserve falsy reusable action parameter overrides
Reject action parameters without workflowId

…and failure actions

…e retry and goto branches

…re actions that don't have a workflowId

Copilot

Copilot review overview

🟡 Changes recommended

Reusable action parameters can reference action components and then be silently omitted from workflow inputs.

Review effort: Balanced
Findings: 1

Open (1)

Reject non-parameter component references in reusable action parameters · New

Resolved since last review (4)

Reject forbidden in fields in action parameters
Require executable action type when workflowId parameters are provided
Preserve falsy reusable action parameter overrides
Reject action parameters without workflowId

+        const actionParameters = action.parameters.map((parameter) =>
+          resolveReusableComponentItem(parameter, ctx)
+        );


…nd of component

…ctions

Copilot

Copilot review overview

🟡 Changes recommended

Parameterized retries fail when retryLimit is omitted, duplicate resolved inputs are silently overwritten, and the feature documentation is incomplete.

Review effort: Balanced
Findings: 1 · 2

Open (3)

Reject non-parameter component references in reusable action parameters
Default omitted retryLimit to one and pass mapped parameters · New
Reject duplicate action parameter names after reference resolution · New

Copilot

Copilot review overview

🟡 Changes recommended

Concurrent runs can corrupt scoped inputs, and exhausted retries skip subsequent failure actions.

Review effort: Balanced
Findings: 2 · 1 · 1

Open (4)

Isolate workflow inputs across concurrent dependency runs · New
Reject non-parameter component references in reusable action parameters
Continue evaluating failure actions after retries are exhausted · New
Require unique name and in combination in diagnostics · New

Resolved since last review (2)

Reject duplicate action parameter names after reference resolution
Default omitted retryLimit to one and pass mapped parameters

+  const inputsBeforeRun = inputs ? ctx.$workflows[workflow.workflowId].inputs : undefined;
+  if (inputs) {
+    ctx.$workflows[workflow.workflowId].inputs = { ...inputsBeforeRun, ...inputs };


+          // the spec retries a step once when the action has no `retryLimit`
+          const { retryAfter, retryLimit = 1 } = action;


+              message:
+                resolvedParameter?.name === undefined
+                  ? 'The parameter `reference` must be unique amongst listed parameters.'
+                  : 'The parameter `name` must be unique amongst listed parameters.',


DmitryAnansky requested a balanced review from Copilot September 29, 2026 12:19

Copilot started reviewing on behalf of DmitryAnansky September 29, 2026 12:20 View session

Copilot AI reviewed Sep 29, 2026

View reviewed changes

DmitryAnansky requested a balanced review from Copilot September 29, 2026 12:49

Copilot started reviewing on behalf of DmitryAnansky September 29, 2026 12:49 View session

Copilot AI reviewed Sep 29, 2026

View reviewed changes

Comment thread packages/respect-core/src/modules/flow-runner/run-step.ts Outdated

DmitryAnansky requested a balanced review from Copilot September 29, 2026 14:08

Copilot started reviewing on behalf of DmitryAnansky September 29, 2026 14:09 View session

Copilot AI reviewed Sep 29, 2026

View reviewed changes

DmitryAnansky requested a balanced review from Copilot September 29, 2026 14:16

Copilot started reviewing on behalf of DmitryAnansky September 29, 2026 14:17 View session

Copilot AI reviewed Sep 29, 2026

View reviewed changes

Comment thread packages/respect-core/src/modules/flow-runner/run-step.ts

Comment thread packages/respect-core/src/modules/flow-runner/run-step.ts

DmitryAnansky force-pushed the feat/support-parameters-on-success-failure-actions branch from 7bf0a8d to db5da12 Compare September 30, 2026 16:29

DmitryAnansky requested a balanced review from Copilot September 30, 2026 16:29

Copilot started reviewing on behalf of DmitryAnansky September 30, 2026 16:30 View session

Copilot AI reviewed Sep 30, 2026

View reviewed changes

Comment thread packages/core/src/types/arazzo1_1.ts Outdated

Comment thread packages/core/src/types/arazzo1_1.ts

DmitryAnansky added 9 commits October 2, 2026 16:46

feat: add support for the Arazzo 1.1.0 parameters field of success …

8789b88

…and failure actions

chore: update docs

4fab5ca

fix: parameters with an in field are silently discarded

da7db8a

fix: avoid the newly added any catch binding

fa7cc20

fix: action parameters are now applied right before runWorkflow in th…

cf8822d

…e retry and goto branches

chore: changes after review

fd93537

chore: changes after review

a0cd23e

fix: struct rule to report parameters on Arazzo 1.1 success and failu…

adcd4d7

…re actions that don't have a workflowId

fix: preserve falsy reusable action parameter overrides

fdb7b65

DmitryAnansky force-pushed the feat/support-parameters-on-success-failure-actions branch from db5da12 to fdb7b65 Compare October 2, 2026 13:46

DmitryAnansky requested a balanced review from Copilot October 2, 2026 13:58

Copilot started reviewing on behalf of DmitryAnansky October 2, 2026 13:58 View session

Copilot AI reviewed Oct 2, 2026

View reviewed changes

Comment thread packages/respect-core/src/modules/flow-runner/run-step.ts

Comment on lines +326 to +328

const actionParameters = action.parameters.map((parameter) =>

resolveReusableComponentItem(parameter, ctx)

);

DmitryAnansky added 3 commits October 2, 2026 17:20

chore: changes after review

c5771f1

fix: respect ignored a Reusable Object that pointed to the wrong ki…

b54cf5d

…nd of component

Merge branch 'main' into feat/support-parameters-on-success-failure-a…

9c36508

…ctions

DmitryAnansky requested a balanced review from Copilot October 2, 2026 15:40

Copilot started reviewing on behalf of DmitryAnansky October 2, 2026 15:41 View session

Copilot AI reviewed Oct 2, 2026

View reviewed changes

Comment thread packages/respect-core/src/modules/flow-runner/run-step.ts

Comment thread packages/respect-core/src/modules/flow-runner/run-step.ts

chore: changes after review

1f2cbd7

DmitryAnansky requested a balanced review from Copilot October 2, 2026 16:34

Copilot started reviewing on behalf of DmitryAnansky October 2, 2026 16:34 View session

Copilot AI reviewed Oct 2, 2026

View reviewed changes

		// the spec retries a step once when the action has no `retryLimit`
		const { retryAfter, retryLimit = 1 } = action;

Conversation

DmitryAnansky commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What/Why/How?

Reference

Testing

Screenshots (optional)

Check yourself

Security

Uh oh!

changeset-bot Bot commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Performance Benchmark (Lower is Faster)

Uh oh!

github-actions Bot commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

DmitryAnansky commented Sep 29, 2026 •

edited

Loading

changeset-bot Bot commented Sep 29, 2026 •

edited

Loading

github-actions Bot commented Sep 29, 2026 •

edited

Loading

github-actions Bot commented Sep 29, 2026 •

edited

Loading