Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add project preview command #1367

Merged
merged 6 commits into from
Jan 16, 2024
Merged

feat: add project preview command #1367

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
67393f6
feat: add project previiew command
volodymyr-rutskyi Dec 22, 2023
2a2fa89
chore: use stdout instead of console.log
volodymyr-rutskyi Dec 22, 2023
d8067e9
Update packages/cli/src/commands/preview-project/index.ts
volodymyr-rutskyi Jan 5, 2024
5d2da6d
fix: apply port argument
volodymyr-rutskyi Jan 5, 2024
7ea8454
chore: command defaults, naming, and descriptions adjustments
volodymyr-rutskyi Jan 8, 2024
a26c262
Merge branch 'main' into feat/project-preview-command
volodymyr-rutskyi Jan 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: apply port argument
  • Loading branch information
@volodymyr-rutskyi
volodymyr-rutskyi committed Jan 5, 2024
commit 5d2da6d021cf022b32ce71fce570c80df0278f21
6 changes: 3 additions & 3 deletions packages/cli/src/commands/preview-project/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { PRODUCT_NAMES, PRODUCT_PACKAGES } from './constants';
import type { PreviewProjectOptions, Product } from './types';

export const previewProject = async (args: PreviewProjectOptions) => {
const { plan } = args;
const { plan, port } = args;
const projectDir = args['project-dir'] || '.';

const product = args.product || tryGetProductFromPackageJson(projectDir);
Expand All @@ -19,9 +19,9 @@ export const previewProject = async (args: PreviewProjectOptions) => {
const productName = PRODUCT_NAMES[product];
const packageName = PRODUCT_PACKAGES[product];

process.stdout.write(`\nLaunching preview of ${productName} ${args.plan} using NPX\n\n`);
process.stdout.write(`\nLaunching preview of ${productName} ${plan} using NPX\n\n`);

spawn('npx', ['-y', packageName, 'develop', `--plan=${plan}`], {
spawn('npx', ['-y', packageName, 'develop', `--plan=${plan}`, `--port=${port || 4000}`], {
stdio: 'inherit',
cwd: projectDir
});
Expand Down
Loading