Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update docs tooling and checks #1330

Merged
merged 15 commits into from
Nov 20, 2023
Merged

docs: Update docs tooling and checks #1330

merged 15 commits into from
Nov 20, 2023

Conversation

lornajane
Copy link
Contributor

@lornajane lornajane commented Nov 14, 2023

What/Why/How?

Following the upgrade on our docs platform, this pull request assembles some updates that were waiting for this change!

Provisional list:

  • fix broken Vale checks on PR (the annotations aren't working due to token permissions)
  • refresh Vale rules and centralise configuration
  • remove outdated jobs, including sync
  • use markdownlint to match destination website repo
  • run prettier on docs folder (as requested in Run prettier for markdown files #1111 )
  • revisit link checker
  • add support for running the Redocly CLI docs standalone
  • update Contributing file so that all contributors can use the docs with confidence
  • move Contributing file to top level of repo

Reference

Testing

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Copy link

changeset-bot bot commented Nov 14, 2023

🦋 Changeset detected

Latest commit: f753c86

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@redocly/cli Patch
@redocly/openapi-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 14, 2023

Command Mean [s] Min [s] Max [s] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 1.005 ± 0.030 0.982 1.088 1.00
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 1.016 ± 0.017 0.990 1.043 1.01 ± 0.03

Copy link
Contributor

github-actions bot commented Nov 14, 2023

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 76.12% 4057/5330
🟡 Branches 65.94% 2151/3262
🟡 Functions 68.3% 657/962
🟡 Lines 76.31% 3805/4986

Test suite run success

646 tests passing in 93 suites.

Report generated by 🧪jest coverage report action from f753c86

@tatomyr
Copy link
Contributor

tatomyr commented Nov 16, 2023

I wonder if it also makes sense to move our contribution guide to the root folder in the scope of this task. I'm not sure why it happens to reside in the .github folder in the first place 🙂

@lornajane
Copy link
Contributor Author

Good idea, I think I will do that. I really prefer to easily find it at the root of the project.

@lornajane
Copy link
Contributor Author

Summarising a discussion with @tatomyr : the website repo that the docs/ folder publishes to uses markdownlint and the exact same rules are used here. This project also uses prettier, which does a lot of the same things. That's fine for now, but if both tools are adopted in the main website in the future, we could try to limit the overlap.

@lornajane lornajane marked this pull request as ready for review November 17, 2023 16:58
@lornajane lornajane requested a review from a team as a code owner November 17, 2023 16:58
@lornajane lornajane requested a review from a team November 17, 2023 16:59
Copy link
Contributor

@HCloward HCloward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, very nice! Thanks for doing all of this work.

Co-authored-by: Ihor Karpiuk <106662428+IgorKarpiuk@users.noreply.github.com>
@lornajane lornajane merged commit afb5d94 into main Nov 20, 2023
30 checks passed
@lornajane lornajane deleted the docops branch November 20, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants