Skip to content

Different output of slowlog get for Redis OSS #1755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

igordr3
Copy link

@igordr3 igordr3 commented Jan 18, 2022

SLOWLOG GET command features different output for Redis OSS compared to Redis Enterprise/Cloud.

In OSS Redis, the slowlog get command gives the following fields:

  1. A unique progressive identifier for every slow log entry.
  2. The unix timestamp at which the logged command was processed.
  3. The amount of time needed for its execution, in microseconds.
  4. The array composing the arguments of the command.
  5. Client IP address and port.
  6. Client name if set via the CLIENT SETNAME command.

Whereas in our Redis Enterprise Cloud DB, the slowlog get command gives the following fields:

  1. A unique progressive identifier for every slow log entry.
  2. The unix timestamp at which the logged command was processed.
  3. The amount of time needed for its execution, in microseconds.
  4. The array composing the arguments of the command.

Hence the documentation to reflect it till we decide on how to proceed further.

SLOWLOG GET command features different output for Redis OSS compared to Redis Enterprise/Cloud.

In OSS Redis, the slowlog get command gives the following fields:

1. A unique progressive identifier for every slow log entry.
2. The unix timestamp at which the logged command was processed.
3. The amount of time needed for its execution, in microseconds.
4. The array composing the arguments of the command.
5. Client IP address and port.
6. Client name if set via the CLIENT SETNAME command.

Whereas in our Redis Enterprise Cloud DB, the slowlog get command gives the following fields:

1. A unique progressive identifier for every slow log entry.
2. The unix timestamp at which the logged command was processed.
3. The amount of time needed for its execution, in microseconds.
4. The array composing the arguments of the command.

Hence the documentation to reflect it till we decide on how to proceed further.
@igordr3
Copy link
Author

igordr3 commented Jan 18, 2022

@lanceleonard Could you review when convenient, please?

@igordr3 igordr3 closed this Jan 18, 2022
@igordr3 igordr3 reopened this Jan 18, 2022
@igordr3 igordr3 marked this pull request as ready for review January 18, 2022 10:16
@lanceleonard
Copy link
Contributor

lanceleonard commented Jan 18, 2022

@igordr3 - I took a quick look when I assigned the PR. Thanks for the contribution; we appreciate the help!

I've already reached out to our product team to verify the info and how we should present it. (We've been trying to think about a better way to present command compatibility info and the FAQs don't really feel like the right place for this level of detail.)

@lanceleonard
Copy link
Contributor

@AlonMagrafta - Please take a look.

Copy link
Contributor

@AlonMagrafta AlonMagrafta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow missed that one for a long time
I suggest to add examples of the output

@lanceleonard lanceleonard self-assigned this Aug 31, 2022
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants