Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-1075 updates to SCC scope #1706

Merged
merged 5 commits into from
Dec 17, 2021
Merged

DOC-1075 updates to SCC scope #1706

merged 5 commits into from
Dec 17, 2021

Conversation

kaitlynmichael
Copy link
Contributor

Labeling as in progress until I confirm this change is only needed in the OpenShift Cli deployment guide.

@kaitlynmichael kaitlynmichael added in progress Changes are in progress K8s Kubernetes labels Dec 15, 2021
@kaitlynmichael kaitlynmichael self-assigned this Dec 15, 2021
@kaitlynmichael kaitlynmichael removed the in progress Changes are in progress label Dec 17, 2021
@kaitlynmichael
Copy link
Contributor Author

I've confirmed this change is only for openshift

lanceleonard
lanceleonard approved these changes Dec 17, 2021
View reviewed changes
Copy link
Contributor

@lanceleonard lanceleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rrelledge
rrelledge approved these changes Dec 17, 2021
View reviewed changes
Copy link
Collaborator

@rrelledge rrelledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I only saw a couple of small typos.

content/kubernetes/deployment/quick-start.md Outdated Show resolved Hide resolved
content/kubernetes/deployment/quick-start.md Outdated Show resolved Hide resolved
kaitlynmichael and others added 2 commits December 17, 2021 09:54
@kaitlynmichael @rrelledge
Update content/kubernetes/deployment/quick-start.md
074618f 
Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com>
@kaitlynmichael
fixed code block formatting
7e91d1f
@kaitlynmichael kaitlynmichael merged commit 1d327ef into master Dec 17, 2021
@kaitlynmichael kaitlynmichael deleted the oc-cli-update branch December 17, 2021 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrelledge rrelledge rrelledge approved these changes

@lanceleonard lanceleonard lanceleonard approved these changes

@bascar bascar Awaiting requested review from bascar

@yuvallevy2 yuvallevy2 Awaiting requested review from yuvallevy2

Assignees

@kaitlynmichael kaitlynmichael

Labels
K8s Kubernetes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaitlynmichael @lanceleonard @rrelledge