Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K8s: revise openshift cli getting started #1675

Merged
merged 10 commits into from
Dec 15, 2021
Merged

K8s: revise openshift cli getting started #1675

merged 10 commits into from
Dec 15, 2021

Conversation

kaitlynmichael
Copy link
Contributor

@kaitlynmichael kaitlynmichael commented Nov 23, 2021 •
edited
Loading

@kaitlynmichael kaitlynmichael added in progress Changes are in progress K8s Kubernetes labels Nov 23, 2021
@kaitlynmichael kaitlynmichael self-assigned this Nov 23, 2021
@kaitlynmichael kaitlynmichael removed the in progress Changes are in progress label Dec 6, 2021
@kaitlynmichael
Copy link
Contributor Author

Staging site: https://docs.redis.com/staging/jira-doc-870/kubernetes/deployment/openshift/openshift-cli/

lanceleonard
lanceleonard suggested changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@lanceleonard lanceleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though a couple of things need to be tweaked.

content/kubernetes/deployment/openshift/openshift-cli.md Outdated Show resolved Hide resolved
content/kubernetes/deployment/openshift/openshift-cli.md Outdated Show resolved Hide resolved
@kaitlynmichael @lanceleonard
Update content/kubernetes/deployment/openshift/openshift-cli.md
61225f9 
Co-authored-by: Lance Leonard <lanceleonard@users.noreply.github.com>
rrelledge
rrelledge approved these changes Dec 6, 2021
View reviewed changes
Copy link
Collaborator

@rrelledge rrelledge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I left a couple of small suggestions.

content/kubernetes/deployment/openshift/openshift-cli.md Outdated Show resolved Hide resolved
content/kubernetes/deployment/openshift/openshift-cli.md Outdated Show resolved Hide resolved
content/kubernetes/deployment/openshift/openshift-cli.md Outdated Show resolved Hide resolved
@kaitlynmichael @rrelledge
Apply suggestions from code review
48af1bc 
Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com>
lanceleonard
lanceleonard approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@lanceleonard lanceleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaitlynmichael kaitlynmichael merged commit 419979e into master Dec 15, 2021
@kaitlynmichael kaitlynmichael deleted the jira-doc-870 branch December 15, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrelledge rrelledge rrelledge approved these changes

@lanceleonard lanceleonard lanceleonard approved these changes

@randv1r randv1r Awaiting requested review from randv1r

@yuvallevy2 yuvallevy2 Awaiting requested review from yuvallevy2

@bascar bascar Awaiting requested review from bascar

Assignees

@kaitlynmichael kaitlynmichael

Labels
K8s Kubernetes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaitlynmichael @lanceleonard @rrelledge