-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update give Cloud access to a GCP user #1087
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmansheim
changed the title
Update account-team-settings.md
Update give Cloud access to a GCP user
Nov 4, 2020
bmansheim
requested review from
Aviad-Abutbul and
joniredis
and removed request for
Aviad-Abutbul
November 4, 2020 12:40
@Aviad-Abutbul I'm happy to review the style and formatting. Can you confirm that we need to make this update? |
@gilbennun I need you to sign the contributor agreement before I can merge this change. |
lanceleonard
approved these changes
Jul 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with suggested edits.
rrelledge
added a commit
that referenced
this pull request
Aug 17, 2021
* Small fix (#1468) back from the dead - also this is ugly. Miss you guys. * can add module only on creation (#1469) * can add module only on creation * Update add-module-to-database.md * Cleaned up RS clients index page and added an auto-generating table shortcode (#1467) * Doc 781 Manage REC credentials procedure (#1466) * Jira DOC-760: RC - Finish reorganizing Concepts content. (#1454) * Initial draft/implementation * Updating glossary link * Adding new section to entry page. * Initial pass to reorg/clean-up Cloud account docs. * Typos and other editorial fixes * Updating flush-all article/mini-toc min word count. * Edits to cloud account entry page * Moving remaining how-to articles to admin sections * RS: Removed v5.2 from version dropdown (#1470) * Add dynatrace issue RED-54704 to upgrade notes (#1464) Dynatrace agent installed on the cluster nodes can hamper the working on Envoy process leading to failure of UI and REST API. Prior upgrading we recommed removing Dynatrace completely or try upgrading to newer versions. * Updated info on REC password and editorial changes (#1471) * Initial draft (#1472) * Update give Cloud access to a GCP user (#1087) * Update account-team-settings.md * Update content/rc/administration/account-team-settings.md * Update content/rc/administration/account-team-settings.md * Update content/rc/administration/account-team-settings.md * Update content/rc/administration/account-team-settings.md Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com> Co-authored-by: Lance Leonard <lanceleonard@users.noreply.github.com> * Changelog: July 2021 updates (#1473) * Initial draft * Typo fix * Update changelog.md Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com> Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com> * Updating admin password on Clusters with CRDB (#1474) * Updating admin password on Clusters with CRDB * Update content/rs/security/admin-console-security/user-security.md Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com> * Update content/rs/security/admin-console-security/user-security.md Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com> * Update content/rs/security/admin-console-security/user-security.md Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com> * Update content/rs/security/admin-console-security/user-security.md Co-authored-by: Lance Leonard <lanceleonard@users.noreply.github.com> * Update content/rs/security/admin-console-security/user-security.md Co-authored-by: Lance Leonard <lanceleonard@users.noreply.github.com> * Update content/rs/security/admin-console-security/user-security.md Co-authored-by: Lance Leonard <lanceleonard@users.noreply.github.com> * Update content/rs/security/admin-console-security/user-security.md Co-authored-by: Lance Leonard <lanceleonard@users.noreply.github.com> * Update content/rs/security/admin-console-security/user-security.md Co-authored-by: Lance Leonard <lanceleonard@users.noreply.github.com> * Update content/rs/security/admin-console-security/user-security.md Co-authored-by: Lance Leonard <lanceleonard@users.noreply.github.com> Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com> Co-authored-by: Lance Leonard <lanceleonard@users.noreply.github.com> * Fixing merge issues * Active Active expiration values (#1475) * Active Active expiration values * Update content/rs/references/developing-for-active-active/_index.md Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com> * Added non-breaking spaces to expiration ranges Co-authored-by: Rachel Elledge <86307637+rrelledge@users.noreply.github.com> * Squashed commit of the following updates commit e26f2e90 Author: Lance Leonard <lanceleonard@users.noreply.github.com> Date: Tue Aug 10 2021 09:37:51 GMT-0500 (Central Daylight Time) Ugh. Tpyo commit 322e1820 Author: Lance Leonard <lanceleonard@users.noreply.github.com> Date: Mon Aug 09 2021 22:52:07 GMT-0500 (Central Daylight Time) More updates commit d589f766 Author: Lance Leonard <lanceleonard@users.noreply.github.com> Date: Mon Aug 09 2021 11:41:30 GMT-0500 (Central Daylight Time) Initial draft of changes commit 46ba9c7a Author: Lance Leonard <lanceleonard@users.noreply.github.com> Date: Fri Aug 06 2021 14:19:43 GMT-0500 (Central Daylight Time) Merge branch 'master' into content-updates to bring up-to-date with other project (though Fri Aug 6) commit 0e20399b Author: Rachel Elledge <rachel.elledge@redislabs.com> Date: Fri Aug 06 2021 10:38:21 GMT-0500 (Central Daylight Time) Updated terraform IAM template json commit 5feb8d43 Author: Rachel Elledge <rachel.elledge@redislabs.com> Date: Fri Aug 06 2021 10:23:00 GMT-0500 (Central Daylight Time) Updated circleci jobs commit 2a79ccb4 Author: Rachel Elledge <rachel.elledge@redislabs.com> Date: Tue Aug 03 2021 14:32:43 GMT-0500 (Central Daylight Time) Updated contribution and editing guides commit a5a66a71 Author: Rachel Elledge <rachel.elledge@redislabs.com> Date: Tue Aug 03 2021 14:30:22 GMT-0500 (Central Daylight Time) Updated site title commit 89cfb28c Author: Rachel Elledge <rachel.elledge@redislabs.com> Date: Tue Jul 27 2021 17:13:57 GMT-0500 (Central Daylight Time) updated footer commit 94ae7731 Author: Rachel Elledge <rachel.elledge@redislabs.com> Date: Tue Jul 27 2021 17:12:44 GMT-0500 (Central Daylight Time) logo commit c8d1f0c2 Author: Rachel Elledge <rachel.elledge@redislabs.com> Date: Tue Jul 27 2021 16:34:56 GMT-0500 (Central Daylight Time) README and LICENSE updates * Squashed commit of the following web updates commit 9b11ae0b Author: Rachel Elledge <rachel.elledge@redislabs.com> Date: Tue Aug 10 2021 10:48:09 GMT-0500 (Central Daylight Time) Updated website.json commit 3ace752e Author: Rachel Elledge <rachel.elledge@redislabs.com> Date: Mon Aug 09 2021 09:08:58 GMT-0500 (Central Daylight Time) Updated robots.txt * A couple more updates * Updated search site url * Updated CircleCI jobs * Logo (#1480) * Updated CircleCI jobs * Fixing CircleCI config bug * Fixing table layout. (Maybe?) (#1482) * Fixing table layout. (Maybe?) * Adding missing newline * Adjusting z-index to fix icon overlap issues * Adding redirect. (#1484) * Updating css test (#1483) * Fixing table layout. (Maybe?) * Adding missing newline * Adjusting z-index to fix icon overlap issues * Updating test rule * Css fix test (#1485) * Fixing table layout. (Maybe?) * Adding missing newline * Adjusting z-index to fix icon overlap issues * Updating test rule * Varying the test * Doc 851 log-collector script instructions (#1486) * Fixed incorrect GTM container and deduped the GA scripts (#1487) * Fixed incorrect GTM ID and deduped GA scripts * Added purge site cache step to CircleCI deploy jobs (#1488) * [Urgent] 6.0.20 known limitation - 2 critical bugs (#1492) * [Urgent] 6.0.20 known limitation - 2 critical bugs * Update rs-6-0-20-april-2021.md Co-authored-by: Jamie Scott <jamie.scott@uconn.edu> Co-authored-by: Alon Magrafta <50071256+AlonMagrafta@users.noreply.github.com> Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com> Co-authored-by: Lance Leonard <lanceleonard@users.noreply.github.com> Co-authored-by: vikrammoule-redislabs <39086205+vikrammoule-redislabs@users.noreply.github.com> Co-authored-by: gilbennun <39088155+gilbennun@users.noreply.github.com>
rrelledge
pushed a commit
that referenced
this pull request
Aug 17, 2021
* Update account-team-settings.md * Update content/rc/administration/account-team-settings.md * Update content/rc/administration/account-team-settings.md * Update content/rc/administration/account-team-settings.md * Update content/rc/administration/account-team-settings.md Co-authored-by: Kaitlyn Michael <76962844+kaitlynmichael@users.noreply.github.com> Co-authored-by: Lance Leonard <lanceleonard@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.